util/test/mac/mach_multiprocess.cc - Issue 640383002: In tests, use ASSERT_NO_FATAL_FAILURE()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/test/mac/mach_multiprocess.cc

Issue 640383002: In tests, use ASSERT_NO_FATAL_FAILURE() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/test/mac/mach_multiprocess.cc

diff --git a/util/test/mac/mach_multiprocess.cc b/util/test/mac/mach_multiprocess.cc

index 568e31479c2abdefa85470b03d0cbbbb9e0421c4..a8503fa3b08c40f9fbcef04e7f1c02c10dedcb69 100644

--- a/util/test/mac/mach_multiprocess.cc

+++ b/util/test/mac/mach_multiprocess.cc

@@ -82,10 +82,7 @@ MachMultiprocess::~MachMultiprocess() {

}

void MachMultiprocess::PreFork() {

- Multiprocess::PreFork();

- if (testing::Test::HasFatalFailure()) {

- return;

- }

+ ASSERT_NO_FATAL_FAILURE(Multiprocess::PreFork());

// Set up the parent port and register it with the bootstrap server before

// forking, so that it’s guaranteed to be there when the child attempts to

« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | util/test/multiprocess.h » ('j') | no next file with comments »