Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: content/content_tests.gypi

Issue 640363002: Make crazy linker work in gn build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-chrome-shell-apk
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/content_tests.gypi
diff --git a/content/content_tests.gypi b/content/content_tests.gypi
index 9299561495922713d067e6736bedb8420ae3706a..f33df7737d7d06285cbbf4c436d65cda36f26a5d 100644
--- a/content/content_tests.gypi
+++ b/content/content_tests.gypi
@@ -1660,7 +1660,7 @@
'includes': [ '../build/apk_test.gypi' ],
},
{
- # TODO(GN)
+ # GN: //content/shell/android:chromium_linker_test_apk
'target_name': 'chromium_linker_test_apk',
'type': 'none',
'conditions': [
@@ -1694,7 +1694,7 @@
],
},
{
- # TODO(GN)
+ # GN: //content/shell/android:linker_test
'target_name': 'chromium_android_linker_test',
'type': 'shared_library',
'defines!': ['CONTENT_IMPLEMENTATION'],
@@ -1711,7 +1711,7 @@
],
},
{
- # TODO(GN)
+ # GN: //content/shell/android:linker_test_jni_headers
'target_name': 'chromium_android_linker_test_jni_headers',
'type': 'none',
'sources': [

Powered by Google App Engine
This is Rietveld 408576698