Make crazy linker work in gn build

base/android/BUILD.gn

Index: base/android/BUILD.gn
diff --git a/base/android/BUILD.gn b/base/android/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..eec970c94c347c6a253119513e4b3c597151ce46
--- /dev/null
+++ b/base/android/BUILD.gn
@@ -0,0 +1,17 @@
+import("//build/config/android/config.gni")
+
+assert(is_android && !is_android_webview_build)

[Yaron, 2014/10/17 19:16:27]

will gn split out each value in the assert? if not, it's probably worth having
separate asserts.

[cjhopman, 2014/10/17 21:05:37]

Done.

+
+shared_library("chromium_android_linker") {
+  sources = [ "linker/linker_jni.cc" ]
+  # The NDK contains the crazy_linker here:
+  #   '<(android_ndk_root)/crazy_linker.gyp:crazy_linker'
+  # However, we use our own fork.  See bug 384700.
+  deps = [ "//third_party/android_crazy_linker" ]
+
+  # TODO(GYP):
+  # The crazy linker is never instrumented.
+  #'cflags!': [
+  #'-finstrument-functions',

[Yaron, 2014/10/17 19:16:27]

why is this commented out?

[cjhopman, 2014/10/17 21:05:20]

The "TODO(GYP)" above marks this as part of the GYP->GN conversion that still
needs to be done.

It's not clear how this will be implemented (note that it is removing a cflag).
This probably can't be done until we have the other parts of order profiling
supported (my understanding is that that is what uses the -finstrument-functions
cflag).

+  #],
+}