base/android/BUILD.gn - Issue 640363002: Make crazy linker work in gn build

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/android/BUILD.gn

Issue 640363002: Make crazy linker work in gn build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-chrome-shell-apk

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 import("//build/config/android/config.gni")

	2

	3 assert(is_android && !is_android_webview_build)
	Yaron 2014/10/17 19:16:27 will gn split out each value in the assert? if not will gn split out each value in the assert? if not, it's probably worth having separate asserts. cjhopman 2014/10/17 21:05:37 Done. Show quoted text On 2014/10/17 19:16:27, Yaron wrote: > will gn split out each value in the assert? if not, it's probably worth having > separate asserts. Done.
	4

	5 shared_library("chromium_android_linker") {

	6 sources = [ "linker/linker_jni.cc" ]

	7 # The NDK contains the crazy_linker here:

	8 # '<(android_ndk_root)/crazy_linker.gyp:crazy_linker'

	9 # However, we use our own fork. See bug 384700.

	10 deps = [ "//third_party/android_crazy_linker" ]

	11

	12 # TODO(GYP):

	13 # The crazy linker is never instrumented.

	14 #'cflags!': [

	15 #'-finstrument-functions',
	Yaron 2014/10/17 19:16:27 why is this commented out? why is this commented out? cjhopman 2014/10/17 21:05:20 The "TODO(GYP)" above marks this as part of the GY Show quoted text On 2014/10/17 19:16:27, Yaron wrote: > why is this commented out? The "TODO(GYP)" above marks this as part of the GYP->GN conversion that still needs to be done. It's not clear how this will be implemented (note that it is removing a cflag). This probably can't be done until we have the other parts of order profiling supported (my understanding is that that is what uses the -finstrument-functions cflag).
	16 #],

	17 }

OLD	NEW

« no previous file with comments | « BUILD.gn ('k') | base/base.gyp » ('j') | no next file with comments »