net/cookies/parsed_cookie.cc - Issue 640303008: Remove trivially-true check in parsed_cookie.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/parsed_cookie.cc

Issue 640303008: Remove trivially-true check in parsed_cookie.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/simpler_bug422036

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cookies/parsed_cookie.cc

diff --git a/net/cookies/parsed_cookie.cc b/net/cookies/parsed_cookie.cc

index 6d82d9ec8d91ca5343e90402e6d3abdfcd3e8ff2..5a11863f48a023e920672149e1cc15b9d09dca4a 100644

--- a/net/cookies/parsed_cookie.cc

+++ b/net/cookies/parsed_cookie.cc

@@ -137,7 +137,7 @@ bool IsValidCookieValue(const std::string& value) {

}

bool IsControlCharacter(unsigned char c) {

- return (c >= 0) && (c <= 31);

+ return c <= 31; // unsigned char is always >= 0.

Ryan Sleevi 2014/10/17 19:17:10 just nuke this comment

}

bool IsValidCookieAttributeValue(const std::string& value) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »