Remove trivially-true check in parsed_cookie.cc

net/cookies/parsed_cookie.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Portions of this code based on Mozilla:
 //   (netwerk/cookie/src/nsCookieService.cpp)
 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
@@ skipping 119 matching lines @@
          (*i >= 0x2D && *i <= 0x3A) ||
          (*i >= 0x3C && *i <= 0x5B) ||
          (*i >= 0x5D && *i <= 0x7E));
     if (!valid_octet)
       return false;
   }
   return true;
 }
 
 bool IsControlCharacter(unsigned char c) {
-    return (c >= 0) && (c <= 31);
+  return c <= 31;  // unsigned char is always >= 0.

[Ryan Sleevi, 2014/10/17 19:17:10]

just nuke this comment

 }
 
 bool IsValidCookieAttributeValue(const std::string& value) {
   // The greatest common denominator of cookie attribute values is
   // <any CHAR except CTLs or ";"> according to RFC 6265.
   for (std::string::const_iterator i = value.begin(); i != value.end(); ++i) {
     if (IsControlCharacter(*i) || *i == ';')
       return false;
   }
   return true;
@@ skipping 338 matching lines @@
   for (size_t i = 0; i < arraysize(indexes); ++i) {
     if (*indexes[i] == index)
       *indexes[i] = 0;
     else if (*indexes[i] > index)
       --*indexes[i];
   }
   pairs_.erase(pairs_.begin() + index);
 }
 
 }  // namespace