Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 640303008: Remove trivially-true check in parsed_cookie.cc (Closed)

Created:
6 years, 2 months ago by Chris Masone
Modified:
6 years, 2 months ago
Reviewers:
jww, Ryan Sleevi
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/simpler_bug422036
Project:
chromium
Visibility:
Public.

Description

Remove trivially-true check in parsed_cookie.cc IsControlCharacter() was checking an unsigned char to make sure it's >= 0, which is trivially true. This throws a warning on the default CrOS toolchain, so remove it even though it's harmless BUG=424334 TEST=net_unittests R=rsleevi@chromium.org Committed: https://crrev.com/f96393cf4def7ba16577c9a484c9f0093124a6a5 Cr-Commit-Position: refs/heads/master@{#300170}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address sleevi's nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/cookies/parsed_cookie.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Chris Masone
Joel landed this code, but Ryan can you OWNERS review?
6 years, 2 months ago (2014-10-17 18:07:09 UTC) #2
jww
lgtm
6 years, 2 months ago (2014-10-17 18:08:54 UTC) #3
Ryan Sleevi
lgtm % nit https://codereview.chromium.org/640303008/diff/1/net/cookies/parsed_cookie.cc File net/cookies/parsed_cookie.cc (right): https://codereview.chromium.org/640303008/diff/1/net/cookies/parsed_cookie.cc#newcode140 net/cookies/parsed_cookie.cc:140: return c <= 31; // unsigned ...
6 years, 2 months ago (2014-10-17 19:17:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640303008/20001
6 years, 2 months ago (2014-10-17 20:15:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-17 22:03:50 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 22:05:10 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f96393cf4def7ba16577c9a484c9f0093124a6a5
Cr-Commit-Position: refs/heads/master@{#300170}

Powered by Google App Engine
This is Rietveld 408576698