Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: public/platform/Platform.h

Issue 640293002: [WebGL-blink] Return meaningful information in WebGL context creation error message (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/canvas/WebGLRenderingContextBase.cpp ('k') | public/platform/WebGraphicsContext3D.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/Platform.h
diff --git a/public/platform/Platform.h b/public/platform/Platform.h
index c319e30c3ab10f33258b52f0ef4015c0d13169d6..ff881cbc8b72edd6270a03b07a187dbd8c663fa9 100644
--- a/public/platform/Platform.h
+++ b/public/platform/Platform.h
@@ -557,7 +557,7 @@ public:
// May return null if GPU is not supported.
// Returns newly allocated and initialized offscreen WebGraphicsContext3D instance.
// Passing an existing context to shareContext will create the new context in the same share group as the passed context.
- virtual WebGraphicsContext3D* createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes&, WebGraphicsContext3D* shareContext) { return 0; }
+ virtual WebGraphicsContext3D* createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes&, WebGraphicsContext3D* shareContext, WebGLInfo& glInfo) { return 0; }
piman 2014/10/10 20:23:06 Please pass output params by pointer, not (non-con
Ken Russell (switch to Gerrit) 2014/10/10 20:47:38 Also, figure out a way to avoid temporarily breaki
sivag 2014/10/27 13:33:51 Done.
virtual WebGraphicsContext3D* createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes&) { return 0; }
// Returns a newly allocated and initialized offscreen context provider. The provider may return a null
« no previous file with comments | « Source/core/html/canvas/WebGLRenderingContextBase.cpp ('k') | public/platform/WebGraphicsContext3D.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698