Source/core/html/canvas/WebGLRenderingContextBase.cpp - Issue 640293002: [WebGL-blink] Return meaningful information in WebGL context creation error message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.cpp

Issue 640293002: [WebGL-blink] Return meaningful information in WebGL context creation error message (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/canvas/WebGLRenderingContextBase.cpp

diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.cpp b/Source/core/html/canvas/WebGLRenderingContextBase.cpp

index 59ed09225afc84ace36e7815e5951a4bb7543303..4902472526d4a622aa51ac7d9d85cd36d8369b07 100644

--- a/Source/core/html/canvas/WebGLRenderingContextBase.cpp

+++ b/Source/core/html/canvas/WebGLRenderingContextBase.cpp

@@ -5536,7 +5536,8 @@ void WebGLRenderingContextBase::maybeRestoreContext(Timer<WebGLRenderingContextB

}

blink::WebGraphicsContext3D::Attributes attributes = m_requestedAttributes->attributes(canvas()->document().topDocument().url().string(), settings, version());

- OwnPtr<blink::WebGraphicsContext3D> context = adoptPtr(blink::Platform::current()->createOffscreenGraphicsContext3D(attributes, 0));

+ blink::WebGLInfo glInfo;

+ OwnPtr<blink::WebGraphicsContext3D> context = adoptPtr(blink::Platform::current()->createOffscreenGraphicsContext3D(attributes, 0, glInfo));

RefPtr<DrawingBuffer> buffer;

if (context) {

// Construct a new drawing buffer with the new WebGraphicsContext3D.

« no previous file with comments | « Source/core/html/canvas/WebGLRenderingContext.cpp ('k') | public/platform/Platform.h » ('j') | public/platform/Platform.h » ('J')