RPHI::AddRoute: Turn a DCHECK() to a CHECK() again.

RPHI::AddRoute: Turn a DCHECK() to a CHECK() again.

This is a revival of [1], which was reverted [2] due to triggering
huge crash. Now the cause of the crash is fixed by [3].
This CHECK() aims to prevent similar bug in the future.

[1] crrev.com/d3e91b36c3c29aee92159db9d5cc331cd3f97241
[2] crrev.com/9a04b3c3f9c85da4510eba67095b61bec78d7b6b
[3] crrev.com/dcdb02fab210ec5f7b8b560075ce96d0f48f344c

R=nasko@chromium.org, kareng@chromium.org
BUG=381990
Committed: https://crrev.com/0181f4ac89929f78f9e88ca18e971031a21d5ae2
Cr-Commit-Position: refs/heads/master@{#299994}

[Hajime Morrita, 2014-10-16 19:46:20]

PTAL? Turns DCHECK to CHECK.

[nasko, 2014-10-16 20:08:57]

https://codereview.chromium.org/640223005/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/640223005/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_process_host_impl.cc:925: << "Found Invalid
Routing ID: " << routing_id;
Why not add the check for duplicate? If we believe that we've found the root
cause and fixed it, it should never trigger, right?

[Hajime Morrita, 2014-10-16 20:41:30]

On 2014/10/16 20:08:57, nasko wrote:
>
https://codereview.chromium.org/640223005/diff/1/content/browser/renderer_hos...
> File content/browser/renderer_host/render_process_host_impl.cc (right):
> 
>
https://codereview.chromium.org/640223005/diff/1/content/browser/renderer_hos...
> content/browser/renderer_host/render_process_host_impl.cc:925: << "Found
Invalid
> Routing ID: " << routing_id;
> Why not add the check for duplicate? If we believe that we've found the root
> cause and fixed it, it should never trigger, right?
Right. Added it back. PTAL?

[nasko, 2014-10-16 20:50:36]

LGTM!

[Hajime Morrita, 2014-10-16 20:58:15]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-10-16 20:58:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640223005/20001

[commit-bot: I haz the power, 2014-10-16 22:26:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-16 22:27:41]

Patchset 2 (id:??) landed as
https://crrev.com/0181f4ac89929f78f9e88ca18e971031a21d5ae2
Cr-Commit-Position: refs/heads/master@{#299994}