Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 640223005: RPHI::AddRoute: Turn a DCHECK() to a CHECK() again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index cbfa1504dcc45c3da2c9ca022ee9573df0cdd2de..ebc142890d975e7c2469e8a0fed4b813ffcc9016 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -921,8 +921,10 @@ ServiceRegistry* RenderProcessHostImpl::GetServiceRegistry() {
void RenderProcessHostImpl::AddRoute(
int32 routing_id,
IPC::Listener* listener) {
- DCHECK(widget_helper_->IsRoutingIDProbablyValid(routing_id))
- << "Found Routing ID conflicts: " << routing_id;
+ CHECK(widget_helper_->IsRoutingIDProbablyValid(routing_id))
+ << "Found Invalid Routing ID: " << routing_id;
+ CHECK(!listeners_.Lookup(routing_id))
+ << "Found Routing ID Conflict: " << routing_id;
listeners_.AddWithID(listener, routing_id);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698