[C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to nullptr [part-…

[C++11 Allowed Features] Declares a type-safe null pointer converting from  NULL to  nullptr [part-5]

BUG =

[ARUNKK, 2014-10-09 09:24:52]

kulkarni.a@samsung.com changed reviewers:
+ danakj@chromium.org

[ARUNKK, 2014-10-09 09:24:53]

PTAL.

[danakj, 2014-10-09 16:00:53]

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_imp...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:1550: SoftwareRenderer::Create(this,
&settings_, output_surface_.get(), nullptr);
and here?

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_impl.h
File cc/trees/layer_tree_host_impl.h (right):

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.h:592: // |resource_provider_| and |tile_manager_|
can be nullptr, e.g. when using tile-
is upload presubmit not warning you about going over 80 columns here?

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_pix...
File cc/trees/layer_tree_host_pixeltest_filters.cc (right):

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_pix...
cc/trees/layer_tree_host_pixeltest_filters.cc:257:
SkColorFilterImageFilter::Create(colorFilter.get(), nullptr, &crop_rect));
and here

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
cc/trees/layer_tree_host_unittest.cc:4936: : num_commits_(0), num_draws_(0),
bounds_(20, 20), child_layer_(nullptr) {}
and here

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
File cc/trees/layer_tree_host_unittest_context.cc (right):

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
cc/trees/layer_tree_host_unittest_context.cc:920: scoped_refptr<TextureLayer>
texture = TextureLayer::CreateForMailbox(nullptr);
and here..

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
File cc/trees/layer_tree_host_unittest_delegated.cc (right):

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
cc/trees/layer_tree_host_unittest_delegated.cc:299: virtual void AfterTest()
override { resource_collection_->SetClient(nullptr); }
and here

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
File cc/trees/layer_tree_host_unittest_no_message_loop.cc (right):

https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
cc/trees/layer_tree_host_unittest_no_message_loop.cc:104:
LayerTreeHost::CreateSingleThreaded(this, this, nullptr, settings, nullptr);
please don't ignore our presubmit warnings. fix up any comments that went past
80 columns, and run git cl format.

[ARUNKK, 2014-10-10 06:55:12]

On 2014/10/09 16:00:53, danakj wrote:
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_imp...
> File cc/trees/layer_tree_host_impl.cc (right):
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_imp...
> cc/trees/layer_tree_host_impl.cc:1550: SoftwareRenderer::Create(this,
> &settings_, output_surface_.get(), nullptr);
> and here?
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_impl.h
> File cc/trees/layer_tree_host_impl.h (right):
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_imp...
> cc/trees/layer_tree_host_impl.h:592: // |resource_provider_| and
|tile_manager_|
> can be nullptr, e.g. when using tile-
> is upload presubmit not warning you about going over 80 columns here?
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_pix...
> File cc/trees/layer_tree_host_pixeltest_filters.cc (right):
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_pix...
> cc/trees/layer_tree_host_pixeltest_filters.cc:257:
> SkColorFilterImageFilter::Create(colorFilter.get(), nullptr, &crop_rect));
> and here
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> File cc/trees/layer_tree_host_unittest.cc (right):
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> cc/trees/layer_tree_host_unittest.cc:4936: : num_commits_(0), num_draws_(0),
> bounds_(20, 20), child_layer_(nullptr) {}
> and here
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> File cc/trees/layer_tree_host_unittest_context.cc (right):
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> cc/trees/layer_tree_host_unittest_context.cc:920: scoped_refptr<TextureLayer>
> texture = TextureLayer::CreateForMailbox(nullptr);
> and here..
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> File cc/trees/layer_tree_host_unittest_delegated.cc (right):
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> cc/trees/layer_tree_host_unittest_delegated.cc:299: virtual void AfterTest()
> override { resource_collection_->SetClient(nullptr); }
> and here
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> File cc/trees/layer_tree_host_unittest_no_message_loop.cc (right):
> 
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> cc/trees/layer_tree_host_unittest_no_message_loop.cc:104:
> LayerTreeHost::CreateSingleThreaded(this, this, nullptr, settings, nullptr);
> please don't ignore our presubmit warnings. fix up any comments that went past
> 80 columns, and run git cl format.

Review comments like presubmit issues are resolved.
PTAL.

[ARUNKK, 2014-10-10 12:43:15]

kulkarni.a@samsung.com changed reviewers:
+ reveman@chromium.org

[ARUNKK, 2014-10-10 12:43:36]

On 2014/10/10 06:55:12, ARUNKK wrote:
> On 2014/10/09 16:00:53, danakj wrote:
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_imp...
> > File cc/trees/layer_tree_host_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_imp...
> > cc/trees/layer_tree_host_impl.cc:1550: SoftwareRenderer::Create(this,
> > &settings_, output_surface_.get(), nullptr);
> > and here?
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_impl.h
> > File cc/trees/layer_tree_host_impl.h (right):
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_imp...
> > cc/trees/layer_tree_host_impl.h:592: // |resource_provider_| and
> |tile_manager_|
> > can be nullptr, e.g. when using tile-
> > is upload presubmit not warning you about going over 80 columns here?
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_pix...
> > File cc/trees/layer_tree_host_pixeltest_filters.cc (right):
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_pix...
> > cc/trees/layer_tree_host_pixeltest_filters.cc:257:
> > SkColorFilterImageFilter::Create(colorFilter.get(), nullptr, &crop_rect));
> > and here
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> > File cc/trees/layer_tree_host_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> > cc/trees/layer_tree_host_unittest.cc:4936: : num_commits_(0), num_draws_(0),
> > bounds_(20, 20), child_layer_(nullptr) {}
> > and here
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> > File cc/trees/layer_tree_host_unittest_context.cc (right):
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> > cc/trees/layer_tree_host_unittest_context.cc:920:
scoped_refptr<TextureLayer>
> > texture = TextureLayer::CreateForMailbox(nullptr);
> > and here..
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> > File cc/trees/layer_tree_host_unittest_delegated.cc (right):
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> > cc/trees/layer_tree_host_unittest_delegated.cc:299: virtual void AfterTest()
> > override { resource_collection_->SetClient(nullptr); }
> > and here
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> > File cc/trees/layer_tree_host_unittest_no_message_loop.cc (right):
> > 
> >
>
https://codereview.chromium.org/640203002/diff/1/cc/trees/layer_tree_host_uni...
> > cc/trees/layer_tree_host_unittest_no_message_loop.cc:104:
> > LayerTreeHost::CreateSingleThreaded(this, this, nullptr, settings, nullptr);
> > please don't ignore our presubmit warnings. fix up any comments that went
past
> > 80 columns, and run git cl format.
> 
> Review comments like presubmit issues are resolved.
> PTAL.

Review comments like presubmit and format issues are resolved.
PTAL.

[danakj, 2014-10-10 16:42:06]

If there's no bug, remove the BUG= line. Is there really no bug?

[danakj, 2014-10-10 16:47:12]

https://codereview.chromium.org/640203002/diff/120001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.h (right):

https://codereview.chromium.org/640203002/diff/120001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.h:593: // |resource_provider_| and |tile_manager_|
can be NULL,e.g. when using tile-
?

https://codereview.chromium.org/640203002/diff/120001/cc/trees/tree_synchroni...
File cc/trees/tree_synchronizer_unittest.cc (right):

https://codereview.chromium.org/640203002/diff/120001/cc/trees/tree_synchroni...
cc/trees/tree_synchronizer_unittest.cc:204:
TreeSynchronizer::SynchronizeTrees(static_cast<Layer*>(nullptr),
static cast isn't needed, remove that please

[Avi (use Gerrit), 2014-10-10 16:54:51]

Your change description makes no sense. "[C++11 Allowed Features] Declares a
type-safe null pointer converting from NULL to  nullptr". This change does not
declare any pointers. This description seems to mash together two sentences:
"C++11 declares a type safe null pointer" and "This change converts from NULL to
nullptr". Please rewrite it to be grammatical English.

Also, if we’re doing a bulk conversion from NULL to nullptr, we should have a
master BUG tying this all together.