Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: tools/telemetry/telemetry/core/wpr_server.py

Issue 640133002: [Telemetry] Properly chose an available device port. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@port
Patch Set: Fix device port unmapping Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/wpr_server.py
diff --git a/tools/telemetry/telemetry/core/wpr_server.py b/tools/telemetry/telemetry/core/wpr_server.py
index a59745e6d6702ee51fe5b360a51915c0f2923a18..be377ab5853db316c9ca6a5b825bbec725f3333b 100644
--- a/tools/telemetry/telemetry/core/wpr_server.py
+++ b/tools/telemetry/telemetry/core/wpr_server.py
@@ -47,10 +47,10 @@ class ReplayServer(object):
# Assign the forwarder port pairs back to the browser_backend.
# The port pairs are used to set up the application.
# The chrome_browser_backend uses the remote ports to set browser flags.
- browser_backend.wpr_port_pairs = self._ForwarderPortPairs(
+ port_pairs = self._ForwarderPortPairs(
started_ports, browser_backend.wpr_port_pairs)
- self._forwarder = browser_backend.forwarder_factory.Create(
- browser_backend.wpr_port_pairs)
+ self._forwarder = browser_backend.forwarder_factory.Create(port_pairs)
+ browser_backend.wpr_port_pairs = self._forwarder.port_pairs
@staticmethod
def _ForwarderPortPairs(started_ports, wpr_port_pairs):
@@ -70,8 +70,8 @@ class ReplayServer(object):
a forwarders.PortPairs instance used to create the forwarder.
"""
local_http_port, local_https_port, local_dns_port = started_ports
- remote_http_port = wpr_port_pairs.http.remote_port or local_http_port
- remote_https_port = wpr_port_pairs.https.remote_port or local_https_port
+ remote_http_port = wpr_port_pairs.http.remote_port
+ remote_https_port = wpr_port_pairs.https.remote_port
http_port_pair = forwarders.PortPair(local_http_port, remote_http_port)
https_port_pair = forwarders.PortPair(local_https_port, remote_https_port)
if wpr_port_pairs.dns is None:
« no previous file with comments | « tools/telemetry/telemetry/core/forwarders/android_forwarder.py ('k') | tools/telemetry/telemetry/core/wpr_server_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698