Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: tools/telemetry/telemetry/core/forwarders/android_forwarder.py

Issue 640133002: [Telemetry] Properly chose an available device port. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@port
Patch Set: Fix device port unmapping Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/forwarders/__init__.py ('k') | tools/telemetry/telemetry/core/wpr_server.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/forwarders/android_forwarder.py
diff --git a/tools/telemetry/telemetry/core/forwarders/android_forwarder.py b/tools/telemetry/telemetry/core/forwarders/android_forwarder.py
index babe33b960726459bd43720d4d0f15d52013f38c..a4c77cf92e07c48a2f85e14fd3d4f07f60ee1cc9 100644
--- a/tools/telemetry/telemetry/core/forwarders/android_forwarder.py
+++ b/tools/telemetry/telemetry/core/forwarders/android_forwarder.py
@@ -54,13 +54,19 @@ class AndroidForwarder(forwarders.Forwarder):
def __init__(self, adb, port_pairs):
super(AndroidForwarder, self).__init__(port_pairs)
self._device = adb.device()
- forwarder.Forwarder.Map([p for p in port_pairs if p], self._device)
+ forwarder.Forwarder.Map([(p.remote_port, p.local_port)
+ for p in port_pairs if p], self._device)
+ self._port_pairs = forwarders.PortPairs(*[
+ forwarders.PortPair(
+ p.local_port,
+ forwarder.Forwarder.DevicePortForHostPort(p.local_port))
+ if p else None for p in port_pairs])
# TODO(tonyg): Verify that each port can connect to host.
def Close(self):
for port_pair in self._port_pairs:
if port_pair:
- forwarder.Forwarder.UnmapDevicePort(port_pair.local_port, self._device)
+ forwarder.Forwarder.UnmapDevicePort(port_pair.remote_port, self._device)
super(AndroidForwarder, self).Close()
« no previous file with comments | « tools/telemetry/telemetry/core/forwarders/__init__.py ('k') | tools/telemetry/telemetry/core/wpr_server.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698