Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java

Issue 640093003: Resolve lint warnings related to ClickableViewAccessibility when a class overrides onTouch event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: resolving lints Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java b/content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java
index 80e7dd2de997365a55ce06b5d4118ee36688d784..908493cad03c20ab18696c3ae4bb168afa0f8efe 100644
--- a/content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java
+++ b/content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java
@@ -81,6 +81,7 @@ class PopupZoomer extends View {
private boolean mAnimating = false;
private boolean mShowing = false;
private long mAnimationStartTime = 0;
+ private boolean mDownTouch = false;
// The time that was left for the outwards animation to finish.
// This is used in the case that the zoomer is cancelled while it is still animating outwards,
@@ -541,6 +542,25 @@ class PopupZoomer extends View {
@Override
public boolean onTouchEvent(MotionEvent event) {
mGestureDetector.onTouchEvent(event);
+ // Listening for the down and up touch events
+ // to enable accessibility services for a user
+ // who cannot click touch screen.
+ switch (event.getAction()) {
+ case MotionEvent.ACTION_DOWN:
+ mDownTouch = true;
+ break;
+ case MotionEvent.ACTION_UP:
+ if (mDownTouch) {
+ mDownTouch = false;
+ performClick();
+ }
+ }
+ return true;
+ }
+
+ @Override
+ public boolean performClick() {
+ super.performClick();
return true;
}

Powered by Google App Engine
This is Rietveld 408576698