chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java - Issue 640093003: Resolve lint warnings related to ClickableViewAccessibility when a class overrides onTouch event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java

Issue 640093003: Resolve lint warnings related to ClickableViewAccessibility when a class overrides onTouch event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolving lints Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java » ('j') | content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java

index a63e2a5159b5de7bf4167bacecce7401e5629998..62ca860f19a6a2790e8844b5383aa0049e58d77c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java

@@ -88,6 +88,9 @@ public class AppMenuButtonHelper implements OnTouchListener {

break;

case MotionEvent.ACTION_UP:

case MotionEvent.ACTION_CANCEL:

+ if (isTouchEventConsumed) {

+ mMenuButton.performClick();

newt (away) 2014/10/20 22:20:53 This isn't the correct usage of performClick(), bu

wajahat 2014/10/21 14:34:56 Done.

+ }

isTouchEventConsumed |= true;

mMenuButton.setPressed(false);

break;