Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 640073005: Pass setScriptableObjectProperty calls on to Pepper again (Closed)

Created:
6 years, 2 months ago by raymes
Modified:
6 years, 2 months ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, chrome-apps-syd-reviews_chromium.org, xiyuan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Pass setScriptableObjectProperty calls on to Pepper again We previously removed the ability for Pepper plugins to intercept properties set on the plugin element as we thought that this private feature wasn't used anywhere. It turns out that this feature is still used by the deprecated gTalk plugin. This patch adds back the ability for the plugin to intercept the call. Note that we are missing the ability (in V8) to detect whether the plugin has actually intercepted the call the avoid passing the SetProperty request onto the DOM element. But that turns out to be inconsequential for the gTalk plugin. BUG=414842 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183492

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
raymes
Hi Jochen, Could you please take a look at this urgently as it's a beta ...
6 years, 2 months ago (2014-10-09 17:00:53 UTC) #2
raymes
6 years, 2 months ago (2014-10-09 17:34:04 UTC) #4
raymes
+haraken PTAL if you have a chance, I'm trying to get this fix in urgently ...
6 years, 2 months ago (2014-10-09 17:41:35 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-09 18:02:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640073005/40001
6 years, 2 months ago (2014-10-09 18:13:19 UTC) #9
raymes
Thank you!! On Thu Oct 09 2014 at 11:02:37 AM <jochen@chromium.org> wrote: > lgtm > ...
6 years, 2 months ago (2014-10-09 18:13:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31012)
6 years, 2 months ago (2014-10-09 20:47:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640073005/40001
6 years, 2 months ago (2014-10-09 20:48:39 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 21:38:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183492

Powered by Google App Engine
This is Rietveld 408576698