Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

Issue 640073005: Pass setScriptableObjectProperty calls on to Pepper again (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp b/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
index 2730cce547b0ac730412b6008953a5dc2597d63d..292d5c075519cf64470020bb11c6373f96ec43c2 100644
--- a/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
@@ -100,6 +100,17 @@ void setScriptableObjectProperty(PropertyType property, v8::Local<v8::Value> val
callNpObjectSetter(instance, property, value, info);
return;
}
+
+ // FIXME: The gTalk pepper plugin is the only plugin to make use of
+ // SetProperty and that is being deprecated. This can be removed as soon as
+ // it goes away.
+ // Call SetProperty on a pepper plugin's scriptable object. Note that we
+ // never set the return value here which would indicate that the plugin has
+ // intercepted the SetProperty call, which means that the property on the
+ // DOM element will also be set. For plugin's that don't intercept the call
+ // (all except gTalk) this makes no difference at all. For gTalk the fact
+ // that the property on the DOM element also gets set is inconsequential.
+ instance->Set(property, value);
}
} // namespace
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698