Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_mac.mm

Issue 640053007: mac: Add metrics for AppKit Fullscreen style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rewrite metrics. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_mac.mm
diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_mac.mm b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_mac.mm
new file mode 100644
index 0000000000000000000000000000000000000000..01757f028669f6ec67b9f1e81bcb4b2a7d994689
--- /dev/null
+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_mac.mm
@@ -0,0 +1,31 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h"
+
+#include "base/mac/sdk_forward_declarations.h"
+#include "base/metrics/histogram.h"
+
+namespace {
+
+// The possible values of the setting "Screens Have Separate Spaces".
+enum SeparateSpaces {
+ SCREENS_HAVE_SEPARATE_SPACES = 0,
+ SCREENS_HAVE_SHARED_SPACES = 1,
+ SEPARATE_SPACES_COUNT = 2
+};
+
+} // namespace
+
+void ChromeBrowserMainExtraPartsMetrics::RecordMacMetrics() {
+ BOOL screens_have_separate_spaces =
+ [NSScreen respondsToSelector:@selector(screensHaveSeparateSpaces)] &&
Robert Sesek 2014/10/20 17:34:46 You may want to collect !respondsToSelector:#selec
erikchen 2014/10/20 18:30:59 I expect your suggested metric to be almost identi
Robert Sesek 2014/10/20 18:54:36 Right, my suggestion would separate out users that
erikchen 2014/10/21 18:44:38 Done.
+ [NSScreen screensHaveSeparateSpaces];
+ int separate_spaces = screens_have_separate_spaces
+ ? SCREENS_HAVE_SEPARATE_SPACES
+ : SCREENS_HAVE_SHARED_SPACES;
+ UMA_HISTOGRAM_ENUMERATION("OSX.Settings.ScreensHaveSeparateSpaces",
+ separate_spaces,
+ SEPARATE_SPACES_COUNT);
+}

Powered by Google App Engine
This is Rietveld 408576698