Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Side by Side Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_mac.mm

Issue 640053007: mac: Add metrics for AppKit Fullscreen style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rewrite metrics. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h"
6
7 #include "base/mac/sdk_forward_declarations.h"
8 #include "base/metrics/histogram.h"
9
10 namespace {
11
12 // The possible values of the setting "Screens Have Separate Spaces".
13 enum SeparateSpaces {
14 SCREENS_HAVE_SEPARATE_SPACES = 0,
15 SCREENS_HAVE_SHARED_SPACES = 1,
16 SEPARATE_SPACES_COUNT = 2
17 };
18
19 } // namespace
20
21 void ChromeBrowserMainExtraPartsMetrics::RecordMacMetrics() {
22 BOOL screens_have_separate_spaces =
23 [NSScreen respondsToSelector:@selector(screensHaveSeparateSpaces)] &&
Robert Sesek 2014/10/20 17:34:46 You may want to collect !respondsToSelector:#selec
erikchen 2014/10/20 18:30:59 I expect your suggested metric to be almost identi
Robert Sesek 2014/10/20 18:54:36 Right, my suggestion would separate out users that
erikchen 2014/10/21 18:44:38 Done.
24 [NSScreen screensHaveSeparateSpaces];
25 int separate_spaces = screens_have_separate_spaces
26 ? SCREENS_HAVE_SEPARATE_SPACES
27 : SCREENS_HAVE_SHARED_SPACES;
28 UMA_HISTOGRAM_ENUMERATION("OSX.Settings.ScreensHaveSeparateSpaces",
29 separate_spaces,
30 SEPARATE_SPACES_COUNT);
31 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698