cc: Make OutputSurface::SwapBuffers pure virtual

cc: Make OutputSurface::SwapBuffers pure virtual

The current implementation is not used in production code
and there is no reasonable common denominator anymore between
the different implementations.

Also removing the compositor example app (which was using
cc::OutputSurface) since James says it's not incredibly useful anymore.

Committed: https://crrev.com/0668048aef27305171af88d6f870f0a041e2b2b7
Cr-Commit-Position: refs/heads/master@{#299173}

[no sievers, 2014-10-09 23:41:13]

sievers@chromium.org changed reviewers:
+ jamesr@chromium.org

[no sievers, 2014-10-09 23:41:21]

ptal

[no sievers, 2014-10-10 00:25:05]

https://codereview.chromium.org/640023004/diff/480001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/640023004/diff/480001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:4439: gfx::Rect expected_swap_rect(0,
0, 500, 500);
Interesting that full swaps are top-left origin...

https://codereview.chromium.org/640023004/diff/480001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:4457: expected_swap_rect =
gfx::Rect(0, 500-28, 26, 28);
and partial swaps are flipped.

[jamesr, 2014-10-10 06:36:40]

lgtm. really glad to see this starting to clean up!

https://codereview.chromium.org/640023004/diff/630001/mojo/cc/direct_output_s...
File mojo/cc/direct_output_surface.h (right):

https://codereview.chromium.org/640023004/diff/630001/mojo/cc/direct_output_s...
mojo/cc/direct_output_surface.h:12: class DirectOutputSurface : public
cc::OutputSurface {
class comment wouldn't hurt

[no sievers, 2014-10-10 18:52:24]

sievers@chromium.org changed reviewers:
+ danakj@chromium.org

[no sievers, 2014-10-10 18:52:44]

+dana: mind stamping the change in
ui/compositor/test/in_process_context_factory.cc?

[danakj, 2014-10-10 18:57:27]

ui LGTM

[no sievers, 2014-10-10 18:57:56]

The CQ bit was checked by sievers@chromium.org

[no sievers, 2014-10-10 18:58:17]

https://codereview.chromium.org/640023004/diff/630001/mojo/cc/direct_output_s...
File mojo/cc/direct_output_surface.h (right):

https://codereview.chromium.org/640023004/diff/630001/mojo/cc/direct_output_s...
mojo/cc/direct_output_surface.h:12: class DirectOutputSurface : public
cc::OutputSurface {
On 2014/10/10 06:36:40, jamesr wrote:
> class comment wouldn't hurt

Done.

[commit-bot: I haz the power, 2014-10-10 18:58:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640023004/780001

[commit-bot: I haz the power, 2014-10-10 20:22:04]

Committed patchset #6 (id:780001)

[commit-bot: I haz the power, 2014-10-10 20:22:45]

Patchset 6 (id:??) landed as
https://crrev.com/0668048aef27305171af88d6f870f0a041e2b2b7
Cr-Commit-Position: refs/heads/master@{#299173}

[no sievers, 2014-10-10 21:46:14]

just fyi and in case it uncovers some bugs or flakiness later:
i was sneaky and removed the actual context swap (and rate limiting based on
that) for PixelOutputSurface since those tests (compositor_unittests, some
content_unittests and cc pixel tests i think) don't really care about that
surface at all.

[danakj, 2014-10-10 21:47:46]

can you point out where that is in this CL?

[no sievers, 2014-10-10 22:10:22]

On 2014/10/10 21:47:46, danakj wrote:
> can you point out where that is in this CL?

PixelTestOutputSurface::SwapBuffers() vs. previously
OutputSurface::SwapBuffers().

Instantiated from:
ui/compositor/test/in_process_context_factory.cc
content/test/web_layer_tree_view_impl_for_testing.cc
cc/test/layer_tree_pixel_test.cc
cc/test/pixel_test.cc