DescriptionThe selection bounds should be clipped to the viewport
This is another regression from
https://codereview.chromium.org/570763003 that wasn't
solved by https://codereview.chromium.org/598113003
as it missed more subtleties: most callers want the
clipped selection bounds. Only one caller actually
cared about the unclipped bounds:
FrameSelection::revealSelection as it needs to know
where the outside-the-viewport-selection is.
This change splits bounds() in 2, depending on
the intended behavior. While touching the code,
switched it to use LayoutRect as none of the
callers cares about FloatRect.
This change fixes
fast/transforms/selection-bounds-in-transformed-view.html
that got broken by using a fractional scroll offset.
Unfortunately no extra test as the issue requires
generating a gigantic drag-image that
DRT doesn't do.
BUG=415917
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183749
Patch Set 1 #Patch Set 2 : Fix the build. #Patch Set 3 : Better fix. #Patch Set 4 : Rebaseline a test. #
Messages
Total messages: 12 (4 generated)
|