Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 640023002: The selection bounds should be clipped to the viewport (Closed)

Created:
6 years, 2 months ago by Julien - ping for review
Modified:
6 years, 2 months ago
Reviewers:
dsinclair, xianzhunzhu, leviw_travelin_and_unemployed
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

The selection bounds should be clipped to the viewport This is another regression from https://codereview.chromium.org/570763003 that wasn't solved by https://codereview.chromium.org/598113003 as it missed more subtleties: most callers want the clipped selection bounds. Only one caller actually cared about the unclipped bounds: FrameSelection::revealSelection as it needs to know where the outside-the-viewport-selection is. This change splits bounds() in 2, depending on the intended behavior. While touching the code, switched it to use LayoutRect as none of the callers cares about FloatRect. This change fixes fast/transforms/selection-bounds-in-transformed-view.html that got broken by using a fractional scroll offset. Unfortunately no extra test as the issue requires generating a gigantic drag-image that DRT doesn't do. BUG=415917 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183749

Patch Set 1 #

Patch Set 2 : Fix the build. #

Patch Set 3 : Better fix. #

Patch Set 4 : Rebaseline a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/transforms/selection-bounds-in-transformed-view-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 2 3 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Julien - ping for review
1-liner for the motivated!
6 years, 2 months ago (2014-10-09 15:03:35 UTC) #2
dsinclair
lgtm
6 years, 2 months ago (2014-10-09 15:09:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640023002/20001
6 years, 2 months ago (2014-10-09 15:10:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/28511)
6 years, 2 months ago (2014-10-09 16:31:39 UTC) #7
Julien - ping for review
New change up for review, there has been quite some extra changes added as I ...
6 years, 2 months ago (2014-10-14 20:03:35 UTC) #8
dsinclair
lgtm
6 years, 2 months ago (2014-10-15 13:10:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640023002/160001
6 years, 2 months ago (2014-10-15 13:10:54 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 13:52:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:160001) as 183749

Powered by Google App Engine
This is Rietveld 408576698