Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 639963006: Make EXPECT_ACTION_UPDATE_STATE failure output easier to understand. (Closed)

Created:
6 years, 2 months ago by mithro-old
Modified:
6 years, 2 months ago
Reviewers:
sunnyps, Sami
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make EXPECT_ACTION_UPDATE_STATE failure output easier to understand. Changes; ------------------------------------------------------------------------------- Value of: state.NextAction() Actual: 1 Expected: SchedulerStateMachine::ACTION_DRAW_AND_SWAP_ABORT Which is: 8 ------------------------------------------------------------------------------- to ------------------------------------------------------------------------------- Value of: SchedulerStateMachine::ActionToString(state.NextAction()) Actual: "ACTION_NONE" Expected: SchedulerStateMachine::ActionToString( SchedulerStateMachine::ACTION_DRAW_AND_SWAP_ABORT) Which is: "ACTION_DRAW_AND_SWAP_ABORT" ------------------------------------------------------------------------------- BUG=416749 Committed: https://crrev.com/06968cb7a6534e631481d0f20b3c666cc2f98805 Cr-Commit-Position: refs/heads/master@{#299282}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
mithro-old
Hi, A small change split out of https://codereview.chromium.org/621883002/ which I don't think will be landable. ...
6 years, 2 months ago (2014-10-13 04:08:06 UTC) #2
Sami
lgtm modulo one question. https://codereview.chromium.org/639963006/diff/1/cc/scheduler/scheduler_state_machine_unittest.cc File cc/scheduler/scheduler_state_machine_unittest.cc (right): https://codereview.chromium.org/639963006/diff/1/cc/scheduler/scheduler_state_machine_unittest.cc#newcode13 cc/scheduler/scheduler_state_machine_unittest.cc:13: EXPECT_STREQ(SchedulerStateMachine::ActionToString(action), \ I'm guessing this ...
6 years, 2 months ago (2014-10-13 09:43:05 UTC) #3
mithro-old
https://codereview.chromium.org/639963006/diff/1/cc/scheduler/scheduler_state_machine_unittest.cc File cc/scheduler/scheduler_state_machine_unittest.cc (right): https://codereview.chromium.org/639963006/diff/1/cc/scheduler/scheduler_state_machine_unittest.cc#newcode13 cc/scheduler/scheduler_state_machine_unittest.cc:13: EXPECT_STREQ(SchedulerStateMachine::ActionToString(action), \ On 2014/10/13 09:43:05, Sami wrote: > I'm ...
6 years, 2 months ago (2014-10-13 10:29:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639963006/1
6 years, 2 months ago (2014-10-13 10:29:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 10:57:14 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 10:58:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06968cb7a6534e631481d0f20b3c666cc2f98805
Cr-Commit-Position: refs/heads/master@{#299282}

Powered by Google App Engine
This is Rietveld 408576698