cc/scheduler/scheduler_state_machine_unittest.cc - Issue 639963006: Make EXPECT_ACTION_UPDATE_STATE failure output easier to understand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/scheduler_state_machine_unittest.cc

Issue 639963006: Make EXPECT_ACTION_UPDATE_STATE failure output easier to understand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler/scheduler_state_machine_unittest.cc

diff --git a/cc/scheduler/scheduler_state_machine_unittest.cc b/cc/scheduler/scheduler_state_machine_unittest.cc

index e19678da023412c6ff5cb9b7dad1c545c68a22fa..286eb478394a9e2b8773a3cc0c35db83911556c2 100644

--- a/cc/scheduler/scheduler_state_machine_unittest.cc

+++ b/cc/scheduler/scheduler_state_machine_unittest.cc

@@ -10,7 +10,9 @@

#include "testing/gtest/include/gtest/gtest.h"

#define EXPECT_ACTION_UPDATE_STATE(action) \

- EXPECT_EQ(action, state.NextAction()) << state.AsValue()->ToString(); \

+ EXPECT_STREQ(SchedulerStateMachine::ActionToString(action), \

Sami 2014/10/13 09:43:05 I'm guessing this doesn't hugely affect the test's

mithro-old 2014/10/13 10:29:10 The change is well within noise on a z620.

+ SchedulerStateMachine::ActionToString(state.NextAction())) \

+ << state.AsValue()->ToString(); \

if (action == SchedulerStateMachine::ACTION_DRAW_AND_SWAP_IF_POSSIBLE || \

action == SchedulerStateMachine::ACTION_DRAW_AND_SWAP_FORCED) { \

EXPECT_EQ(SchedulerStateMachine::BEGIN_IMPL_FRAME_STATE_INSIDE_DEADLINE, \

« no previous file with comments | « no previous file | no next file » | no next file with comments »