Issue 639833004: change more OVERRIDE instances to override in gin/

Issue 639833004: change more OVERRIDE instances to override in gin/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore

Modified:
6 years, 2 months ago

Reviewers:
anujsharma, jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

change more OVERRIDE instances to override in gin/ BUG=417463 Committed: https://crrev.com/efdb7662cfef2020322e1e2bdbb0646020b4ff89 Cr-Commit-Position: refs/heads/master@{#298856}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	gin/modules/module_registry_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/modules/module_runner_delegate.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	gin/modules/timer.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	gin/modules/timer_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/public/v8_platform.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	gin/shell/gin_main.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/test/file_runner.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/test/v8_test.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

Mostyn Bramley-Moore

@anujsharma: I think you missed some OVERRIDE instances in https://codereview.chromium.org/629153002 @jochen: PTAL

6 years, 2 months ago (2014-10-08 22:12:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639833004/1

6 years, 2 months ago (2014-10-09 11:46:33 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as be4236b79c3f76157c7a3ad4038ea707bfebf4bf

6 years, 2 months ago (2014-10-09 12:49:54 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-09 12:50:55 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/efdb7662cfef2020322e1e2bdbb0646020b4ff89
Cr-Commit-Position: refs/heads/master@{#298856}