Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 629153002: Replacing the OVERRIDE with override and FINAL with final in /src/gin (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
CC:
chromium-reviews, MRV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in /src/gin This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/e548191bdc2dd87ad7dd223ea1699c0b79c46695 Cr-Commit-Position: refs/heads/master@{#298220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M gin/array_buffer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M gin/interceptor_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M gin/run_microtasks_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gin/shell_runner.h View 1 chunk +3 lines, -3 lines 0 comments Download
M gin/wrappable_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-06 09:29:21 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-06 09:35:43 UTC) #3
anujsharma
On 2014/10/06 09:35:43, jochen wrote: > lgtm Thanks jochen for lgtm.
6 years, 2 months ago (2014-10-06 09:36:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629153002/1
6 years, 2 months ago (2014-10-06 09:37:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4d84a2c85ef097c8356faa6854438d2fb5fc863c
6 years, 2 months ago (2014-10-06 11:24:25 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 11:25:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e548191bdc2dd87ad7dd223ea1699c0b79c46695
Cr-Commit-Position: refs/heads/master@{#298220}

Powered by Google App Engine
This is Rietveld 408576698