Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 639773010: Prevent division by 0 in set_luminance shader function. (Closed)

Created:
6 years, 2 months ago by rosca
Modified:
5 years, 6 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent division by 0 in set_luminance shader function. The solution has been approved in skia: https://codereview.chromium.org/666043003/ BUG= Committed: https://crrev.com/fd7bcf3a5419a86e4903f43e3dd016e33929082e Cr-Commit-Position: refs/heads/master@{#301333} CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Patch Set 2 : adjusting test error values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M cc/output/shader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_blending.cc View 1 1 chunk +9 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
rosca
Please review.
6 years, 2 months ago (2014-10-24 09:57:33 UTC) #2
enne (OOO)
lgtm
6 years, 1 month ago (2014-10-24 22:57:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639773010/1
6 years, 1 month ago (2014-10-25 06:49:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/5143)
6 years, 1 month ago (2014-10-25 07:42:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639773010/20001
6 years, 1 month ago (2014-10-27 09:19:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 10:07:28 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 10:08:06 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd7bcf3a5419a86e4903f43e3dd016e33929082e
Cr-Commit-Position: refs/heads/master@{#301333}

Powered by Google App Engine
This is Rietveld 408576698