Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: mojo/tools/mojob.sh

Issue 639713002: mojo: Add python bindings tests to mojob.sh (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/mojob.sh
diff --git a/mojo/tools/mojob.sh b/mojo/tools/mojob.sh
index e0804d1ef656f98b6bd27c800c66d5a204c0f763..1d2a86752b456ffd39560aa4e10cc48cbc9776d0 100755
--- a/mojo/tools/mojob.sh
+++ b/mojo/tools/mojob.sh
@@ -19,7 +19,7 @@ command should be one of:
build - Build.
test - Run unit tests (does not build).
perftest - Run perf tests (does not build).
- pytest - Run Python unit tests.
+ pytest - Run Python unit tests (does not build).
gyp - Run gyp for mojo (does not sync).
gypall - Run gyp for all of chromium (does not sync).
sync - Sync using gclient (does not run gyp).
@@ -67,6 +67,10 @@ do_perftests() {
do_pytests() {
python mojo/tools/run_mojo_python_tests.py || exit 1
+ if [ "$COMPONENT" = "static" ]; then
viettrungluu 2014/10/08 16:06:32 This is rather dubious, since the component flags
qsr 2014/10/08 16:16:07 Unfortunately, I do not have a good solution for t
+ python mojo/tools/run_mojo_python_bindings_tests.py \
+ "--build-dir=out/$1" || exit 1
viettrungluu 2014/10/08 16:06:33 And if it runs things out of a particular build di
qsr 2014/10/08 16:16:08 Done.
+ fi
}
do_gyp() {
@@ -180,7 +184,8 @@ for arg in "$@"; do
should_do_Release && do_perftests Release
;;
pytest)
- do_pytests
+ should_do_Debug && do_pytests Debug
+ should_do_Release && do_pytests Release
;;
gyp)
set_goma_dir_if_necessary
@@ -236,3 +241,5 @@ for arg in "$@"; do
;;
esac
done
+
+exit 0
viettrungluu 2014/10/08 16:06:32 Is there a reason for adding this?
qsr 2014/10/08 16:16:08 The script exit with 1 when called for debug. My
viettrungluu 2014/10/09 22:49:52 Sorry, what was the case (e.g., command-line) when
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698