mojo: Add python bindings tests to mojob.sh

mojo/tools/mojob.sh

 #!/bin/bash
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This a simple script to make building/testing Mojo components easier (on
 # Linux).
 
 # TODO(vtl): Maybe make the test runner smart and not run unchanged test
 # binaries.
 # TODO(vtl) Maybe also provide a way to pass command-line arguments to the test
 # binaries.
 
 do_help() {
   cat << EOF
 Usage: $(basename "$0") [command|option ...]
 
 command should be one of:
   build - Build.
   test - Run unit tests (does not build).
   perftest - Run perf tests (does not build).
-  pytest - Run Python unit tests.
+  pytest - Run Python unit tests (does not build).
   gyp - Run gyp for mojo (does not sync).
   gypall - Run gyp for all of chromium (does not sync).
   sync - Sync using gclient (does not run gyp).
   show-bash-alias - Outputs an appropriate bash alias for mojob. In bash do:
       \$ eval \`mojo/tools/mojob.sh show-bash-alias\`
 
 option (which will only apply to following commands) should be one of:
   Build/test options (specified before build/test/perftest):
     --debug - Build/test in Debug mode.
     --release - Build/test in Release mode.
@@ skipping 27 matching lines @@
       mojob_test_successes || exit 1
 }
 
 do_perftests() {
   echo "Running perf tests in out/$1 ..."
   "out/$1/mojo_public_system_perftests" || exit 1
 }
 
 do_pytests() {
   python mojo/tools/run_mojo_python_tests.py || exit 1
+  if [ "$COMPONENT" = "static" ]; then

[viettrungluu, 2014/10/08 16:06:32]

This is rather dubious, since the component flags typically only affect
gyp/gypall, so one wouldn't usually specify it when running tests.

[qsr, 2014/10/08 16:16:07]

 Unfortunately, I do not have a good solution for this :( The generated python
modules do not work in component builds...

 Do you have a suggestion?

+    python mojo/tools/run_mojo_python_bindings_tests.py \
+        "--build-dir=out/$1" || exit 1

[viettrungluu, 2014/10/08 16:06:33]

And if it runs things out of a particular build directory, it should tell you
which one.

[qsr, 2014/10/08 16:16:08]

Done.

+  fi
 }
 
 do_gyp() {
   local gyp_defines="$(make_gyp_defines)"
   echo "Running gyp for mojo with GYP_DEFINES=$gyp_defines ..."
   GYP_DEFINES="$gyp_defines" build/gyp_chromium mojo/mojo.gyp || exit 1
 }
 
 do_gypall() {
   local gyp_defines="$(make_gyp_defines)"
@@ skipping 93 matching lines @@
       ;;
     test)
       should_do_Debug && do_unittests Debug
       should_do_Release && do_unittests Release
       ;;
     perftest)
       should_do_Debug && do_perftests Debug
       should_do_Release && do_perftests Release
       ;;
     pytest)
-      do_pytests
+      should_do_Debug && do_pytests Debug
+      should_do_Release && do_pytests Release
       ;;
     gyp)
       set_goma_dir_if_necessary
       do_gyp
       ;;
     gypall)
       set_goma_dir_if_necessary
       do_gypall
       ;;
     sync)
@@ skipping 35 matching lines @@
       ;;
     --no-use-goma)
       GOMA=disabled
       ;;
     *)
       echo "Unknown command \"${arg}\". Try \"$(basename "$0") help\"."
       exit 1
       ;;
   esac
 done
+
+exit 0

[viettrungluu, 2014/10/08 16:06:32]

Is there a reason for adding this?

[qsr, 2014/10/08 16:16:08]

 The script exit with 1 when called for debug.

 My guess is that it doesn't like to have the last called instruction be a false
|| 

[viettrungluu, 2014/10/09 22:49:52]

Sorry, what was the case (e.g., command-line) when it exited with 1?
But which one would that be (given that it's always "|| exit 1"?