components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java - Issue 639703004: Optimizing DateTimeAndroid and ColorChooserAndroid initializations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java

Issue 639703004: Optimizing DateTimeAndroid and ColorChooserAndroid initializations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed nits. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/web_contents_delegate_android/color_chooser_android.cc » ('j') | content/browser/android/date_time_chooser_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java

diff --git a/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java

index c276916f65e18c761b81b7f724f72118fbf35447..1bac698060070b44e18eba95deac268491cf3da0 100644

--- a/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java

+++ b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java

@@ -8,7 +8,7 @@ import android.content.Context;

import org.chromium.base.CalledByNative;

import org.chromium.base.JNINamespace;

-import org.chromium.content.browser.ContentViewCore;

+import org.chromium.content_public.browser.WebContents;

import org.chromium.ui.ColorPickerDialog;

import org.chromium.ui.ColorSuggestion;

import org.chromium.ui.OnColorChangedListener;

@@ -48,11 +48,11 @@ public class ColorChooserAndroid {

@CalledByNative

public static ColorChooserAndroid createColorChooserAndroid(

long nativeColorChooserAndroid,

- ContentViewCore contentViewCore,

+ WebContents webContents,

int initialColor,

ColorSuggestion[] suggestions) {

ColorChooserAndroid chooser = new ColorChooserAndroid(nativeColorChooserAndroid,

- contentViewCore.getContext(), initialColor, suggestions);

+ webContents.getContext(), initialColor, suggestions);

Yaron 2014/10/15 20:32:38 From a preliminary look, it appears that Applicati

AKVT 2014/10/29 18:13:28 Done. Thank you

chooser.openColorChooser();

return chooser;

}

« no previous file with comments | « no previous file | components/web_contents_delegate_android/color_chooser_android.cc » ('j') | content/browser/android/date_time_chooser_android.h » ('J')