Optimizing DateTimeAndroid and ColorChooserAndroid initializations.

components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.components.web_contents_delegate_android;
 
 import android.content.Context;
 
 import org.chromium.base.CalledByNative;
 import org.chromium.base.JNINamespace;
-import org.chromium.content.browser.ContentViewCore;
+import org.chromium.content_public.browser.WebContents;
 import org.chromium.ui.ColorPickerDialog;
 import org.chromium.ui.ColorSuggestion;
 import org.chromium.ui.OnColorChangedListener;
 
 /**
  * ColorChooserAndroid communicates with the java ColorPickerDialog and the
  * native color_chooser_android.cc
  */
 @JNINamespace("web_contents_delegate_android")
 public class ColorChooserAndroid {
@@ skipping 19 matching lines @@
     }
 
     @CalledByNative
     public void closeColorChooser() {
         mDialog.dismiss();
     }
 
     @CalledByNative
     public static ColorChooserAndroid createColorChooserAndroid(
             long nativeColorChooserAndroid,
-            ContentViewCore contentViewCore,
+            WebContents webContents,
             int initialColor,
             ColorSuggestion[] suggestions) {
         ColorChooserAndroid chooser = new ColorChooserAndroid(nativeColorChooserAndroid,
-            contentViewCore.getContext(), initialColor, suggestions);
+            webContents.getContext(), initialColor, suggestions);

[Yaron, 2014/10/15 20:32:38]

From a preliminary look, it appears that ApplicationContext is sufficient for
this usage. If that's the case, then I'd prefer you use
base::android::GetApplciationContext in native, and pass that up before we
starting adding Context members to WebContents.

[AKVT, 2014/10/29 18:13:28]

Done. Thank you

         chooser.openColorChooser();
         return chooser;
     }
 
     @CalledByNative
     private static ColorSuggestion[] createColorSuggestionArray(int size) {
         return new ColorSuggestion[size];
     }
 
     /**
      * @param array ColorSuggestion array that should get a new suggestion added.
      * @param index Index in the array where to place a new suggestion.
      * @param color Color of the suggestion.
      * @param label Label of the suggestion.
      */
     @CalledByNative
     private static void addToColorSuggestionArray(ColorSuggestion[] array, int index,
             int color, String label) {
         array[index] = new ColorSuggestion(color, label);
     }
 
     // Implemented in color_chooser_android.cc
     private native void nativeOnColorChosen(long nativeColorChooserAndroid, int color);
 }