Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 63943006: Re-enable solid background color optimization for composited layers. (Closed)

Created:
7 years, 1 month ago by dshwang
Modified:
7 years ago
Reviewers:
danakj, jamesr, shawnsingh
CC:
blink-reviews, shans, eae+blinkwatch, Steve Block, dino_apple.com, rwlbuis, krit, alancutter (OOO until 2018), bemjb+rendering_chromium.org, dsinclair, danakj, dstockwell, Timothy Loh, Rik, jchaffraix+rendering, pdr., Eric Willigers, rjwright, zoltan1, darktears, leviw+renderwatch, blink-layers+watch_chromium.org, Mike Lawther (Google), Stephen Chennney, alokp, shawnsingh, Ian Vollick, enne (OOO)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Re-enable solid background color optimization for composited layers. This has two parts: 1.) Make GraphicsLayer::setContentsToSolidColor() handle a solid color layer. 2.) Remove GraphicsLayer::supportsBackgroundColorContent() because we have only one compositor implementation. BUG=114658, 232846 TEST=compositing/background-color/background-color-change-to-text.html compositing/background-color/background-color-change-to-transparent.html compositing/background-color/* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162737

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : Add compositing/webgl/webgl-with-accelerated-background-color.html #

Patch Set 5 : Add compositing/webgl/webgl-with-accelerated-background-color.html #

Patch Set 6 : Add compositing/webgl/webgl-with-accelerated-background-color.html #

Patch Set 7 : Add more tests to TestExpectations to fix mac build #

Patch Set 8 : Add --no-find-copies option to not mess up wrong comparison #

Patch Set 9 : Fix build bot #

Total comments: 1

Patch Set 10 : Remove unnecessary the 'type' and 'media' attributes. Rebase to upstream. #

Patch Set 11 : Add window.internals.forceCompositingUpdate(document) to webgl test to avoid flaky #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -488 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 1 chunk +77 lines, -0 lines 0 comments Download
M LayoutTests/compositing/background-color/background-color-change-to-text.html View 1 3 chunks +13 lines, -4 lines 0 comments Download
M LayoutTests/compositing/background-color/background-color-change-to-text-expected.html View 1 1 chunk +11 lines, -25 lines 0 comments Download
A + LayoutTests/compositing/background-color/background-color-change-to-transparent.html View 1 2 3 4 5 6 7 8 9 3 chunks +12 lines, -5 lines 0 comments Download
A LayoutTests/compositing/background-color/background-color-change-to-transparent-expected.html View 1 2 3 4 5 6 7 8 9 1 chunk +29 lines, -0 lines 0 comments Download
M LayoutTests/compositing/columns/composited-in-paginated-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/contents-opaque/background-color-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/contents-opaque/body-background-painted-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/contents-opaque/body-background-skipped-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/contents-opaque/layer-opacity-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/contents-opaque/layer-transform-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/ancestor-overflow-change-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/clip-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/clip-inside-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/clip-with-shadow-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/fixed-position-composited-switch-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/flipped-writing-mode-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/limit-layer-bounds-fixed-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/limit-layer-bounds-positioned-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/limit-layer-bounds-transformed-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/iframes/become-composited-nested-iframes-expected.txt View 3 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/compositing/iframes/become-overlapped-iframe-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/iframes/composited-parent-iframe-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/iframes/connect-compositing-iframe-delayed-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/iframes/connect-compositing-iframe-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/iframes/connect-compositing-iframe2-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/iframes/connect-compositing-iframe3-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/iframes/enter-compositing-iframe-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/iframes/iframe-resize-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/iframes/iframe-size-from-zero-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/iframes/invisible-nested-iframe-hide-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/iframes/overlapped-iframe-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/iframes/overlapped-iframe-iframe-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/iframes/overlapped-nested-iframes-expected.txt View 3 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/compositing/iframes/resizer-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/animation-overlap-with-children-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-and-transform-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-nonscrollable-body-mismatch-containers-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-nonscrollable-body-overlap-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-positioning-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt View 3 chunks +0 lines, -14 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt View 3 chunks +0 lines, -14 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overflow-scroll-overlap-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-animation-clipping-expected.txt View 3 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-animation-container-expected.txt View 6 chunks +0 lines, -12 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-animation-expected.txt View 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-clipping-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-transformed-3d-expected.txt View 2 chunks +0 lines, -12 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-transformed-layer-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt View 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-transforms-expected.txt View 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/scroll-partial-update-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/spanOverlapsCanvas-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/stacking-context-overlap-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/stacking-context-overlap-nested-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/layer-creation/translatez-overlap-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/overflow-trumps-transform-style-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/overflow/clear-scroll-parent-expected.txt View 6 chunks +0 lines, -12 lines 0 comments Download
M LayoutTests/compositing/overflow/clip-descendents-expected.txt View 2 3 4 chunks +0 lines, -8 lines 0 comments Download
M LayoutTests/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/overflow/composited-scrolling-paint-phases-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/overflow/content-gains-scrollbars-expected.txt View 4 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/compositing/overflow/opt-in-all-layers-after-unclipped-descendant-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/compositing/overflow/opt-unclipped-descendants-into-composited-scrolling-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/overflow/overflow-scrollbar-layers-expected.txt View 4 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/compositing/overflow/resize-painting-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-inside-composited-intermediate-layer-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-with-composited-child-expected.txt View 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/compositing/repaint/repaint-into-ancestor-after-layout-expected.txt View 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-absolute-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-absolute-overflow-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-fixed-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-iframe-absolute-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-iframe-fixed-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-iframe-relative-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-relative-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/tiled-layers-hidpi-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/transitions/transitions-have-composited-layers-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
A LayoutTests/compositing/webgl/webgl-with-accelerated-background-color.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +84 lines, -0 lines 1 comment Download
A LayoutTests/compositing/webgl/webgl-with-accelerated-background-color-expected.html View 1 2 3 4 5 6 7 8 9 1 chunk +35 lines, -0 lines 0 comments Download
M LayoutTests/css3/compositing/mix-blend-mode-composited-layers-expected.txt View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/css3/filters/filtered-compositing-descendant-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/overflow/content-gains-scrollbars-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/overflow/overflow-scrollbar-layers-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/overflow/resize-painting-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/iframes/become-overlapped-iframe-expected.txt View 1 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/iframes/composited-parent-iframe-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/iframes/connect-compositing-iframe-delayed-expected.txt View 1 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/iframes/connect-compositing-iframe-expected.txt View 1 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/iframes/connect-compositing-iframe2-expected.txt View 1 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/iframes/connect-compositing-iframe3-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/iframes/enter-compositing-iframe-expected.txt View 1 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/iframes/iframe-resize-expected.txt View 1 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/iframes/iframe-size-from-zero-expected.txt View 1 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/iframes/overlapped-iframe-expected.txt View 1 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/iframes/resizer-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/layer-creation/animation-overlap-with-children-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt View 1 3 chunks +0 lines, -14 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt View 1 3 chunks +0 lines, -14 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/overflow/content-gains-scrollbars-expected.txt View 1 4 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/overflow/overflow-scrollbar-layers-expected.txt View 1 4 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/overflow/resize-painting-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/tiled-layers-hidpi-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/GraphicsLayer.h View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/platform/graphics/GraphicsLayer.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +21 lines, -0 lines 0 comments Download
M Source/core/rendering/CompositedLayerMapping.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
dshwang
https://codereview.chromium.org/14407003 disabled solid background color optimization because of issue 232846. And then, jamesr@ find the ...
7 years, 1 month ago (2013-11-19 16:42:55 UTC) #1
jamesr
Would any of these tests catch the original regression?
7 years, 1 month ago (2013-11-21 21:02:11 UTC) #2
dshwang
On 2013/11/21 21:02:11, jamesr wrote: > Would any of these tests catch the original regression? ...
7 years, 1 month ago (2013-11-22 12:19:04 UTC) #3
dshwang
Currently, Issue 232846 can not be reproduced even with the patch that is reverted from ...
7 years, 1 month ago (2013-11-22 18:47:21 UTC) #4
dshwang
https://codereview.chromium.org/63943006/diff/60001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/63943006/diff/60001/LayoutTests/TestExpectations#newcode326 LayoutTests/TestExpectations:326: crbug.com/114658 virtual/softwarecompositing/transitions/scale-transition-no-start.html [ NeedsRebaseline ] All tests have minor ...
7 years, 1 month ago (2013-11-22 18:49:48 UTC) #5
jamesr
On 2013/11/22 18:47:21, dshwang wrote: > Currently, Issue 232846 can not be reproduced even with ...
7 years, 1 month ago (2013-11-22 22:18:55 UTC) #6
jamesr
Patch lgtm - this is great. Let's keep a careful eye out for regression but ...
7 years, 1 month ago (2013-11-22 22:26:58 UTC) #7
dshwang
On 2013/11/22 22:18:55, jamesr wrote: > > I tried to change graphics layer from solid ...
7 years ago (2013-11-25 09:53:09 UTC) #8
dshwang
7 years ago (2013-11-26 05:53:16 UTC) #9
jamesr
It looks like a good test. I'm not sure I really understand the setTimeout()s - ...
7 years ago (2013-11-26 06:07:59 UTC) #10
dshwang
On 2013/11/26 06:07:59, jamesr wrote: > It looks like a good test. I'm not sure ...
7 years ago (2013-11-26 07:46:11 UTC) #11
dshwang
https://codereview.chromium.org/63943006/diff/430001/LayoutTests/compositing/webgl/webgl-with-accelerated-background-color.html File LayoutTests/compositing/webgl/webgl-with-accelerated-background-color.html (right): https://codereview.chromium.org/63943006/diff/430001/LayoutTests/compositing/webgl/webgl-with-accelerated-background-color.html#newcode40 LayoutTests/compositing/webgl/webgl-with-accelerated-background-color.html:40: window.internals.forceCompositingUpdate(document); @jamesr, I add this line to ensure re-evaluating ...
7 years ago (2013-11-26 11:49:00 UTC) #12
jamesr
On 2013/11/26 11:49:00, dshwang wrote: > https://codereview.chromium.org/63943006/diff/430001/LayoutTests/compositing/webgl/webgl-with-accelerated-background-color.html > File LayoutTests/compositing/webgl/webgl-with-accelerated-background-color.html > (right): > > https://codereview.chromium.org/63943006/diff/430001/LayoutTests/compositing/webgl/webgl-with-accelerated-background-color.html#newcode40 ...
7 years ago (2013-11-26 18:19:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/63943006/430001
7 years ago (2013-11-26 20:00:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/63943006/430001
7 years ago (2013-11-27 08:37:40 UTC) #15
commit-bot: I haz the power
7 years ago (2013-11-27 09:40:10 UTC) #16
Message was sent while issue was closed.
Change committed as 162737

Powered by Google App Engine
This is Rietveld 408576698