Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 639283004: Keeping golden screenshots in Google Storage (Closed)

Created:
6 years, 2 months ago by Lisa Ignatyeva
Modified:
6 years, 2 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Now golden screenshots are kept in Google Storage. To download them automatically, a hook should be added to .gclient. Specifying directories for golden screenshots and artifacts is optional now. There is also a python script that should be run to update screenshots in Google Storage after using update mode. BUG=395653 Committed: https://crrev.com/340cab2eadc16dd1ef0e9c4295dbaa28e61c4073 Cr-Commit-Position: refs/heads/master@{#299109}

Patch Set 1 #

Patch Set 2 : undo changes in DEPS #

Patch Set 3 : fixed paths, added arguments to python utility #

Patch Set 4 : license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -8 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/screenshot_testing/golden_screenshots/LoginUITest-LoginUIVisible_golden_screenshot.png.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc View 1 2 2 chunks +6 lines, -8 lines 0 comments Download
A tools/screenshot_testing/update_golden_screenshots.py View 1 2 3 1 chunk +99 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Lisa Ignatyeva
6 years, 2 months ago (2014-10-09 18:18:00 UTC) #2
Denis Kuznetsov (DE-MUC)
I don't like hard-coded default paths for golden screenshots / artifacts, especially having them under ...
6 years, 2 months ago (2014-10-10 09:25:09 UTC) #3
Lisa Ignatyeva
Fixed that.
6 years, 2 months ago (2014-10-10 12:28:46 UTC) #4
Denis Kuznetsov (DE-MUC)
lgtm
6 years, 2 months ago (2014-10-10 12:56:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639283004/120001
6 years, 2 months ago (2014-10-10 12:57:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16915)
6 years, 2 months ago (2014-10-10 13:04:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639283004/320001
6 years, 2 months ago (2014-10-10 13:24:34 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:320001)
6 years, 2 months ago (2014-10-10 14:04:36 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 14:05:25 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/340cab2eadc16dd1ef0e9c4295dbaa28e61c4073
Cr-Commit-Position: refs/heads/master@{#299109}

Powered by Google App Engine
This is Rietveld 408576698