chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h - Issue 639283004: Keeping golden screenshots in Google Storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h

Issue 639283004: Keeping golden screenshots in Google Storage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: license Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/screenshot_testing/golden_screenshots/LoginUITest-LoginUIVisible_golden_screenshot.png.sha1 ('k') | chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h

diff --git a/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h b/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h

index a44269d780d68f8c8ae2b7050583e827a93fae6f..0f4562e9d9957f0723a326e8237936ea5a41c145 100644

--- a/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h

+++ b/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h

@@ -148,6 +148,9 @@ class ScreenshotTester {

// be used to compare images.

bool pdiff_enabled_;

+ // Is true when switches specify that artifacts should be saved somewhere.

+ bool generate_artifacts_;

// Vector which holds areas which the comparison ignores because

// them being different is not a bug (e.g. time on the clock).

std::vector<SkIRect> ignored_areas_;