Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 639283003: [turbofan] IA: TruncateFloat64ToFloat32 supports mem operand (Closed)

Created:
6 years, 2 months ago by Weiliang
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] IA: TruncateFloat64ToFloat32 supports mem operand BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24541

Patch Set 1 #

Patch Set 2 : ia32 port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -8 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Weiliang
PTAL
6 years, 2 months ago (2014-10-09 11:42:33 UTC) #2
dcarney
lgtm i'm ooto, can someone land this?
6 years, 2 months ago (2014-10-09 19:13:55 UTC) #3
dcarney
6 years, 2 months ago (2014-10-13 07:13:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24541 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698