Remote assistance on Chrome OS Part IV - It2MeHost

remoting/host/it2me/it2me_native_messaging_host.h

Index: remoting/host/it2me/it2me_native_messaging_host.h
diff --git a/remoting/host/it2me/it2me_native_messaging_host.h b/remoting/host/it2me/it2me_native_messaging_host.h
index 18e738bc46ace83c9a6b40a45638a7735c9e559d..2986da005e630e164c9e0dfcde3d73c03d37138e 100644
--- a/remoting/host/it2me/it2me_native_messaging_host.h
+++ b/remoting/host/it2me/it2me_native_messaging_host.h
@@ -17,14 +17,23 @@ class DictionaryValue;
 class Value;
 }  // namespace base
 
+namespace policy {
+class PolicyService;
+}  // namespace policy
+
 namespace remoting {
 
 // Implementation of the native messaging host process.
 class It2MeNativeMessagingHost : public It2MeHost::Observer,
                                  public extensions::NativeMessageHost {
  public:
-  It2MeNativeMessagingHost(scoped_refptr<AutoThreadTaskRunner> task_runner,
-                           scoped_ptr<It2MeHostFactory> factory);
+  static scoped_ptr<NativeMessageHost> CreateForChromeOS(
+      scoped_refptr<net::URLRequestContextGetter> url_request_context_getter,
+      policy::PolicyService* policy_service);
+
+  It2MeNativeMessagingHost(
+      scoped_ptr<ChromotingHostContext> context,
+      scoped_ptr<It2MeHostFactory> factory);

[Jamie, 2014/10/14 01:18:42]

Having both a Create method and a ctor doesn't seem right here. Could you have
Create/CreateForChromeOS like you did for the host context?

[kelvinp, 2014/10/15 23:03:10]

Done.

   virtual ~It2MeNativeMessagingHost();
 
   // extensions::NativeMessageHost implementation.
@@ -60,6 +69,7 @@ class It2MeNativeMessagingHost : public It2MeHost::Observer,
   Client* client_;
   scoped_ptr<It2MeHostFactory> factory_;
   scoped_ptr<ChromotingHostContext> host_context_;
+  scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
   scoped_refptr<It2MeHost> it2me_host_;
 
   // Cached, read-only copies of |it2me_host_| session state.