Remote assistance on Chrome OS Part IV - It2MeHost

remoting/host/it2me/it2me_native_messaging_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_IT2ME_IT2ME_NATIVE_MESSAGING_HOST_H_
 #define REMOTING_HOST_IT2ME_IT2ME_NATIVE_MESSAGING_HOST_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "extensions/browser/api/messaging/native_message_host.h"
 #include "remoting/base/auto_thread_task_runner.h"
 #include "remoting/host/it2me/it2me_host.h"
 
 namespace base {
 class DictionaryValue;
 class Value;
 }  // namespace base
 
+namespace policy {
+class PolicyService;
+}  // namespace policy
+
 namespace remoting {
 
 // Implementation of the native messaging host process.
 class It2MeNativeMessagingHost : public It2MeHost::Observer,
                                  public extensions::NativeMessageHost {
  public:
-  It2MeNativeMessagingHost(scoped_refptr<AutoThreadTaskRunner> task_runner,
-                           scoped_ptr<It2MeHostFactory> factory);
+  static scoped_ptr<NativeMessageHost> CreateForChromeOS(
+      scoped_refptr<net::URLRequestContextGetter> url_request_context_getter,
+      policy::PolicyService* policy_service);
+
+  It2MeNativeMessagingHost(
+      scoped_ptr<ChromotingHostContext> context,
+      scoped_ptr<It2MeHostFactory> factory);

[Jamie, 2014/10/14 01:18:42]

Having both a Create method and a ctor doesn't seem right here. Could you have
Create/CreateForChromeOS like you did for the host context?

[kelvinp, 2014/10/15 23:03:10]

Done.

   virtual ~It2MeNativeMessagingHost();
 
   // extensions::NativeMessageHost implementation.
   virtual void OnMessage(const std::string& message) override;
   virtual void Start(Client* client) override;
   virtual scoped_refptr<base::SingleThreadTaskRunner> task_runner()
       const override;
 
   // It2MeHost::Observer implementation.
   virtual void OnClientAuthenticated(const std::string& client_username)
@@ skipping 15 matching lines @@
                       scoped_ptr<base::DictionaryValue> response);
   void ProcessDisconnect(const base::DictionaryValue& message,
                          scoped_ptr<base::DictionaryValue> response);
   void SendErrorAndExit(scoped_ptr<base::DictionaryValue> response,
                         const std::string& description) const;
   void SendMessageToClient(scoped_ptr<base::DictionaryValue> message) const;
 
   Client* client_;
   scoped_ptr<It2MeHostFactory> factory_;
   scoped_ptr<ChromotingHostContext> host_context_;
+  scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
   scoped_refptr<It2MeHost> it2me_host_;
 
   // Cached, read-only copies of |it2me_host_| session state.
   It2MeHostState state_;
   std::string access_code_;
   base::TimeDelta access_code_lifetime_;
   std::string client_username_;
 
   // IT2Me Talk server configuration used by |it2me_host_| to connect.
   XmppSignalStrategy::XmppServerConfig xmpp_server_config_;
 
   // Chromoting Bot JID used by |it2me_host_| to register the host.
   std::string directory_bot_jid_;
 
   base::WeakPtr<It2MeNativeMessagingHost> weak_ptr_;
   base::WeakPtrFactory<It2MeNativeMessagingHost> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(It2MeNativeMessagingHost);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_IT2ME_IT2ME_NATIVE_MESSAGING_HOST_H_