Issue 639023004: Oilpan: move HistoryItem to the heap.

Issue 639023004: Oilpan: move HistoryItem to the heap. (Closed)

Created:
6 years, 2 months ago by sof

Modified:
6 years, 2 months ago

Reviewers:
oilpan-reviews, tkent, haraken

CC:
blink-reviews, dglazkov+blink, Nate Chapin, gavinp+loader_chromium.org, mkwst+moarreviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Oilpan: move HistoryItem to the heap. Doing so removes a FrameLoader-reachable Persistent reference to a DocumentState. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184228

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -27 lines)			Patch
M	Source/core/loader/FrameLoader.h	View	2 chunks	+12 lines, -3 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/loader/HistoryItem.h	View	4 chunks	+9 lines, -6 lines	0 comments	Download
M	Source/core/loader/HistoryItem.cpp	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	Source/web/ContextMenuClientImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebHistoryItem.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/web/tests/PinchViewportTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/tests/WebFrameTest.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/web/tests/WebViewTest.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	public/web/WebHistoryItem.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 8 (3 generated)

sof

Please take a look. Following up on a Frame-tangential object that was punted on initially.

6 years, 2 months ago (2014-10-22 16:09:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639023004/1

6 years, 2 months ago (2014-10-23 01:44:37 UTC) #7

commit-bot: I haz the power

6 years, 2 months ago (2014-10-23 02:10:35 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184228