Source/web/tests/WebFrameTest.cpp - Issue 639023004: Oilpan: move HistoryItem to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 639023004: Oilpan: move HistoryItem to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 06ab259edc5c2df04e0c34037d51f19f123cf507..161e5154fe611380857d329ac9792ed5e43537a7 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -5502,7 +5502,7 @@ TEST_F(WebFrameTest, BackToReload)

webViewHelper.initializeAndLoad(m_baseURL + "fragment_middle_click.html", true);

WebFrame* frame = webViewHelper.webView()->mainFrame();

const FrameLoader& mainFrameLoader = webViewHelper.webViewImpl()->mainFrameImpl()->frame()->loader();

- RefPtr<HistoryItem> firstItem = mainFrameLoader.currentItem();

+ RefPtrWillBePersistent<HistoryItem> firstItem = mainFrameLoader.currentItem();

EXPECT_TRUE(firstItem);

registerMockedHttpURLLoad("white-1x1.png");

@@ -5567,7 +5567,7 @@ TEST_F(WebFrameTest, LoadHistoryItemReload)

webViewHelper.initializeAndLoad(m_baseURL + "fragment_middle_click.html", true);

WebFrame* frame = webViewHelper.webView()->mainFrame();

const FrameLoader& mainFrameLoader = webViewHelper.webViewImpl()->mainFrameImpl()->frame()->loader();

- RefPtr<HistoryItem> firstItem = mainFrameLoader.currentItem();

+ RefPtrWillBePersistent<HistoryItem> firstItem = mainFrameLoader.currentItem();

EXPECT_TRUE(firstItem);

registerMockedHttpURLLoad("white-1x1.png");

@@ -5832,7 +5832,7 @@ TEST_F(WebFrameTest, SameDocumentHistoryNavigationCommitType)

TestDidNavigateCommitTypeWebFrameClient client;

FrameTestHelpers::WebViewHelper webViewHelper;

WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(m_baseURL + "push_state.html", true, &client);

- RefPtr<HistoryItem> item = toLocalFrame(webViewImpl->page()->mainFrame())->loader().currentItem();

+ RefPtrWillBePersistent<HistoryItem> item = toLocalFrame(webViewImpl->page()->mainFrame())->loader().currentItem();

runPendingTasks();

toLocalFrame(webViewImpl->page()->mainFrame())->loader().loadHistoryItem(item.get(), FrameLoadTypeBackForward, HistorySameDocumentLoad);

« no previous file with comments | « Source/web/tests/PinchViewportTest.cpp ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »