Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 63883004: Make second argument to CSSStyleSheet.insertRule() optional again (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase on master Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 664 matching lines...) Expand 10 before | Expand all | Expand 10 after
675 675
676 case ScrollTopBodyNotQuirksMode: 676 case ScrollTopBodyNotQuirksMode:
677 return "body.scrollTop is deprecated in strict mode. Please use 'documen tElement.scrollTop' if in strict mode and 'body.scrollTop' only if in quirks mod e."; 677 return "body.scrollTop is deprecated in strict mode. Please use 'documen tElement.scrollTop' if in strict mode and 'body.scrollTop' only if in quirks mod e.";
678 678
679 case ScrollLeftBodyNotQuirksMode: 679 case ScrollLeftBodyNotQuirksMode:
680 return "body.scrollLeft is deprecated in strict mode. Please use 'docume ntElement.scrollLeft' if in strict mode and 'body.scrollLeft' only if in quirks mode."; 680 return "body.scrollLeft is deprecated in strict mode. Please use 'docume ntElement.scrollLeft' if in strict mode and 'body.scrollLeft' only if in quirks mode.";
681 681
682 case ShowModalDialog: 682 case ShowModalDialog:
683 return "Chromium is considering deprecating showModalDialog. Please use window.open and postMessage instead."; 683 return "Chromium is considering deprecating showModalDialog. Please use window.open and postMessage instead.";
684 684
685 case CSSStyleSheetInsertRuleOptionalArg:
686 return "Calling CSSStyleSheet.insertRule() with one argument is deprecat ed. Please pass the index argument as well: insertRule(x, 0).";
687
685 // Features that aren't deprecated don't have a deprecation message. 688 // Features that aren't deprecated don't have a deprecation message.
686 default: 689 default:
687 return String(); 690 return String();
688 } 691 }
689 } 692 }
690 693
691 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 694 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
692 { 695 {
693 ASSERT(feature >= firstCSSProperty); 696 ASSERT(feature >= firstCSSProperty);
694 ASSERT(feature <= lastCSSProperty); 697 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
723 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 726 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
724 { 727 {
725 // FIXME: We may want to handle stylesheets that have multiple owners 728 // FIXME: We may want to handle stylesheets that have multiple owners
726 // http://crbug.com/242125 729 // http://crbug.com/242125
727 if (sheetContents && sheetContents->hasSingleOwnerNode()) 730 if (sheetContents && sheetContents->hasSingleOwnerNode())
728 return getFrom(sheetContents->singleOwnerDocument()); 731 return getFrom(sheetContents->singleOwnerDocument());
729 return 0; 732 return 0;
730 } 733 }
731 734
732 } // namespace WebCore 735 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698