Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 638573002: [webkitpy] Merge ChromiumBuildBot class into the BuildBot class. (Closed)

Created:
6 years, 2 months ago by elecro
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[webkitpy] Merge ChromiumBuildBot class into the BuildBot class. Move the ChromiumBuildBot class logic into the BuildBot class. Also remove some workarounds for detecting if the builder is a Chromium builder. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -121 lines) Patch
M Tools/Scripts/webkitpy/common/host.py View 2 chunks +0 lines, -10 lines 0 comments Download
M Tools/Scripts/webkitpy/common/host_mock.py View 2 chunks +0 lines, -4 lines 0 comments Download
M Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py View 2 chunks +3 lines, -5 lines 0 comments Download
M Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py View 3 chunks +16 lines, -6 lines 0 comments Download
D Tools/Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py View 1 chunk +0 lines, -47 lines 0 comments Download
D Tools/Scripts/webkitpy/common/net/buildbot/chromiumbuildbot_unittest.py View 1 chunk +0 lines, -43 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 3 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/mocktool.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
elecro
PTAL
6 years, 2 months ago (2014-10-07 18:08:29 UTC) #2
Dirk Pranke
lgtm
6 years, 2 months ago (2014-10-08 01:40:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638573002/1
6 years, 2 months ago (2014-10-08 08:15:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/28222)
6 years, 2 months ago (2014-10-08 10:29:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638573002/1
6 years, 2 months ago (2014-10-08 10:39:28 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 11:42:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183408

Powered by Google App Engine
This is Rietveld 408576698