Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2761)

Unified Diff: Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py

Issue 638573002: [webkitpy] Merge ChromiumBuildBot class into the BuildBot class. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
diff --git a/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py b/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
index 25607df3dfefda5014962e16934b4ab6cc4fd19b..d73db5e640e0ebd245e0afc263fe62534c4c0264 100644
--- a/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
+++ b/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
@@ -54,12 +54,10 @@ class Builder(object):
return self._name
def results_url(self):
- return "%s/results/%s" % (self._buildbot.buildbot_url, self.url_encoded_name())
+ return config_urls.chromium_results_url_base_for_builder(self._name)
- # In addition to per-build results, the build.chromium.org builders also
- # keep a directory that accumulates test results over many runs.
def accumulated_results_url(self):
- return None
+ return config_urls.chromium_accumulated_results_url_base_for_builder(self._name)
def latest_layout_test_results_url(self):
return self.accumulated_results_url() or self.latest_cached_build().results_url();
@@ -217,7 +215,7 @@ class Build(object):
class BuildBot(object):
_builder_factory = Builder
- _default_url = config_urls.buildbot_url
+ _default_url = config_urls.chromium_buildbot_url
def __init__(self, url=None):
self.buildbot_url = url if url else self._default_url
« no previous file with comments | « Tools/Scripts/webkitpy/common/host_mock.py ('k') | Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698