Issue 638423003: Split off remaining runtime functions in runtime.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 638423003: Split off remaining runtime functions in runtime.cc. (Closed)

Created:
6 years, 2 months ago by Yang

Modified:
6 years, 2 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3256 lines, -3212 lines)			Patch
M	BUILD.gn	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/macros.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime/runtime.cc	View	3 chunks	+5 lines, -3210 lines	0 comments	Download
A	src/runtime/runtime-api.cc	View	1 chunk	+127 lines, -0 lines	0 comments	Download
A	src/runtime/runtime-array.cc	View	1 chunk	+1161 lines, -0 lines	0 comments	Download
M	src/runtime/runtime-debug.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	src/runtime/runtime-internal.cc	View	1 chunk	+283 lines, -0 lines	0 comments	Download
M	src/runtime/runtime-numbers.cc	View	2 chunks	+16 lines, -0 lines	0 comments	Download
A	src/runtime/runtime-object.cc	View	1 chunk	+1642 lines, -0 lines	0 comments	Download
M	src/runtime/runtime-strings.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

LGTM, but maybe wait 'til evening with the commit.

6 years, 2 months ago (2014-10-10 04:04:33 UTC) #2

Yang

6 years, 2 months ago (2014-10-10 15:00:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24533 (presubmit successful).