Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 638243002: replace OVERRIDE with override in third_party/libaddressinput/chromium/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE with override in third_party/libaddressinput/chromium/ BUG=417463 Committed: https://crrev.com/3473f2aabb77a12ad3d01ab0805438c920526d49 Cr-Commit-Position: refs/heads/master@{#298821}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove addition to README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_metadata_source.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_metadata_source.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_storage_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Mostyn Bramley-Moore
@Rouslan: can you please take a look at this small change?
6 years, 2 months ago (2014-10-08 22:50:57 UTC) #2
please use gerrit instead
https://codereview.chromium.org/638243002/diff/1/third_party/libaddressinput/README.chromium File third_party/libaddressinput/README.chromium (right): https://codereview.chromium.org/638243002/diff/1/third_party/libaddressinput/README.chromium#newcode22 third_party/libaddressinput/README.chromium:22: - Use override directly instead of an OVERRIDE macro ...
6 years, 2 months ago (2014-10-08 23:13:38 UTC) #3
Mostyn Bramley-Moore
https://codereview.chromium.org/638243002/diff/1/third_party/libaddressinput/README.chromium File third_party/libaddressinput/README.chromium (right): https://codereview.chromium.org/638243002/diff/1/third_party/libaddressinput/README.chromium#newcode22 third_party/libaddressinput/README.chromium:22: - Use override directly instead of an OVERRIDE macro ...
6 years, 2 months ago (2014-10-08 23:32:18 UTC) #4
please use gerrit instead
lgtm
6 years, 2 months ago (2014-10-09 00:32:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638243002/20001
6 years, 2 months ago (2014-10-09 00:38:02 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-09 03:17:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638243002/20001
6 years, 2 months ago (2014-10-09 06:05:24 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 06793cb85e1bca457b5cfa2ff918dedbda67b5e7
6 years, 2 months ago (2014-10-09 07:15:23 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 07:17:10 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3473f2aabb77a12ad3d01ab0805438c920526d49
Cr-Commit-Position: refs/heads/master@{#298821}

Powered by Google App Engine
This is Rietveld 408576698