third_party/libaddressinput/README.chromium - Issue 638243002: replace OVERRIDE with override in third_party/libaddressinput/chromium/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libaddressinput/README.chromium

Issue 638243002: replace OVERRIDE with override in third_party/libaddressinput/chromium/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: The library to input, validate, and display addresses.	1 Name: The library to input, validate, and display addresses.

2 Short Name: libaddressinput	2 Short Name: libaddressinput

3 URL: https://code.google.com/p/libaddressinput/	3 URL: https://code.google.com/p/libaddressinput/

4 Version: 0	4 Version: 0

5 Date: 26 August 2014	5 Date: 26 August 2014

6 Revision: 334	6 Revision: 334

7 License: Apache 2.0	7 License: Apache 2.0

8 License File: LICENSE	8 License File: LICENSE

9 Security Critical: no	9 Security Critical: no

10	10

11 Description:	11 Description:

12	12

13 This library lets you enter, validate, and display an address with correct	13 This library lets you enter, validate, and display an address with correct

14 semantics for many countries around the world. The library uses the serialized	14 semantics for many countries around the world. The library uses the serialized

15 validation rules from a Google-managed server (without SLA) at	15 validation rules from a Google-managed server (without SLA) at

16 https://i18napis.appspot.com/ssl-aggregate-address. The library is used in	16 https://i18napis.appspot.com/ssl-aggregate-address. The library is used in

17 requestAutocomplete dialog and autofill.	17 requestAutocomplete dialog and autofill.

18	18

19 Local Modifications:	19 Local Modifications:

20 - Use Chrome's version of JSON reader in chromium/json.cc.	20 - Use Chrome's version of JSON reader in chromium/json.cc.

21 - Use Chrome's version of loose string comparison in chromium/string_compare.cc.	21 - Use Chrome's version of loose string comparison in chromium/string_compare.cc.

	22 - Use override directly instead of an OVERRIDE macro in chromium/*.
	please use gerrit instead 2014/10/08 23:13:38 Please remove this line. I only place here modific Please remove this line. I only place here modifications that affect code in src/third_party/libaddressinput/src, which your change does not. Mostyn Bramley-Moore 2014/10/08 23:32:18 Done (I added that since the presubmit check sugge Show quoted text On 2014/10/08 23:13:38, Rouslan Solomakhin wrote: > Please remove this line. I only place here modifications that affect code in > src/third_party/libaddressinput/src, which your change does not. Done (I added that since the presubmit check suggested it).
OLD	NEW

« no previous file with comments | « no previous file | third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc » ('j') | no next file with comments »