Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 638213004: cc: Remove WebLayerImpl::invalidateRect(WebFloatRect) (Closed)

Created:
6 years, 2 months ago by danakj
Modified:
6 years, 2 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Remove WebLayerImpl::invalidateRect(WebFloatRect) The base method was removed in https://codereview.chromium.org/646133002/ so this is dead code. R=enne BUG=342848 Committed: https://crrev.com/0d12d775889aaaf41985fcf00be3b579c361c522 Cr-Commit-Position: refs/heads/master@{#299773}

Patch Set 1 #

Patch Set 2 : rm-invalidatefloatrect: . #

Patch Set 3 : rm-invalidatefloatrect: . #

Patch Set 4 : rm-invalidatefloatrect: . #

Patch Set 5 : rm-invalidatefloatrect: . #

Total comments: 3

Patch Set 6 : rm-invalidatefloatrect: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M cc/blink/web_layer_impl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/blink/web_layer_impl_fixed_bounds.h View 1 2 3 4 5 1 chunk +7 lines, -7 lines 0 comments Download
M cc/blink/web_layer_impl_fixed_bounds.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
danakj
6 years, 2 months ago (2014-10-14 16:38:04 UTC) #1
danakj
https://codereview.chromium.org/638213004/diff/100001/cc/blink/web_layer_impl_fixed_bounds.h File cc/blink/web_layer_impl_fixed_bounds.h (right): https://codereview.chromium.org/638213004/diff/100001/cc/blink/web_layer_impl_fixed_bounds.h#newcode29 cc/blink/web_layer_impl_fixed_bounds.h:29: const blink::WebFloatPoint3D& transform_origin) override; I left the override on ...
6 years, 2 months ago (2014-10-14 18:00:56 UTC) #3
enne (OOO)
lgtm https://codereview.chromium.org/638213004/diff/100001/cc/blink/web_layer_impl_fixed_bounds.h File cc/blink/web_layer_impl_fixed_bounds.h (right): https://codereview.chromium.org/638213004/diff/100001/cc/blink/web_layer_impl_fixed_bounds.h#newcode32 cc/blink/web_layer_impl_fixed_bounds.h:32: virtual void setTransform(const SkMatrix44& transform); This doesn't need ...
6 years, 2 months ago (2014-10-14 19:27:27 UTC) #4
danakj
https://codereview.chromium.org/638213004/diff/100001/cc/blink/web_layer_impl_fixed_bounds.h File cc/blink/web_layer_impl_fixed_bounds.h (right): https://codereview.chromium.org/638213004/diff/100001/cc/blink/web_layer_impl_fixed_bounds.h#newcode32 cc/blink/web_layer_impl_fixed_bounds.h:32: virtual void setTransform(const SkMatrix44& transform); On 2014/10/14 19:27:27, enne ...
6 years, 2 months ago (2014-10-14 19:28:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638213004/120001
6 years, 2 months ago (2014-10-15 20:13:58 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:120001)
6 years, 2 months ago (2014-10-15 21:34:37 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 21:35:14 UTC) #9
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/0d12d775889aaaf41985fcf00be3b579c361c522
Cr-Commit-Position: refs/heads/master@{#299773}

Powered by Google App Engine
This is Rietveld 408576698