cc: Remove WebLayerImpl::invalidateRect(WebFloatRect)

cc/blink/web_layer_impl_fixed_bounds.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_BLINK_WEB_LAYER_IMPL_FIXED_BOUNDS_H_
 #define CC_BLINK_WEB_LAYER_IMPL_FIXED_BOUNDS_H_
 
 #include "cc/blink/web_layer_impl.h"
 #include "ui/gfx/size.h"
 #include "ui/gfx/transform.h"
 
 namespace cc_blink {
 
 // A special implementation of WebLayerImpl for layers that its contents
 // need to be automatically scaled when the bounds changes. The compositor
 // can efficiently handle the bounds change of such layers if the bounds
 // is fixed to a given value and the change of bounds are converted to
 // transformation scales.
 class WebLayerImplFixedBounds : public WebLayerImpl {
  public:
   CC_BLINK_EXPORT WebLayerImplFixedBounds();
-  CC_BLINK_EXPORT explicit WebLayerImplFixedBounds(scoped_refptr<cc::Layer>);
+  CC_BLINK_EXPORT explicit WebLayerImplFixedBounds(
+      scoped_refptr<cc::Layer> layer);
   virtual ~WebLayerImplFixedBounds();
 
   // WebLayerImpl overrides.
-  virtual void invalidateRect(const blink::WebFloatRect& rect) override;
   virtual void invalidateRect(const blink::WebRect& rect) override;
   virtual void setTransformOrigin(
-      const blink::WebFloatPoint3D& transform_origin);
-  virtual void setBounds(const blink::WebSize& bounds);
-  virtual blink::WebSize bounds() const;
+      const blink::WebFloatPoint3D& transform_origin) override;

[danakj, 2014/10/14 18:00:56]

I left the override on invalidateRect and added them to the others. these are
overriding WebLayerImpl which is on the chromium side so they should be there.
clang plugin doesn't enforce this tho since it doesn't notice the chromium side
overrode the blink side. But these break when you change the blink side of the
codebase if they are missing.

+  virtual void setBounds(const blink::WebSize& bounds) override;
+  virtual blink::WebSize bounds() const override;
   virtual void setTransform(const SkMatrix44& transform);

[enne (OOO), 2014/10/14 19:27:27]

This doesn't need an override?

[danakj, 2014/10/14 19:28:21]

oops missed

-  virtual SkMatrix44 transform() const;
+  virtual SkMatrix44 transform() const override;
 
   CC_BLINK_EXPORT void SetFixedBounds(gfx::Size bounds);
 
  protected:
   void SetTransformInternal(const gfx::Transform& transform);
   void UpdateLayerBoundsAndTransform();
 
   gfx::Transform original_transform_;
   gfx::Size original_bounds_;
   gfx::Size fixed_bounds_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(WebLayerImplFixedBounds);
 };
 
 }  // namespace cc_blink
 
 #endif  // CC_BLINK_WEB_LAYER_IMPL_FIXED_BOUNDS_H_