Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 638143003: Enabled EXT_sRGB WebGL extension support in the command buffer. (Closed)

Created:
6 years, 2 months ago by bajones
Modified:
6 years, 2 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enabled EXT_sRGB WebGL extension support in the command buffer. BUG=386048 Committed: https://crrev.com/2a2ea235a39a4b0bcad1f75934bdc09fb4d41733 Cr-Commit-Position: refs/heads/master@{#299371}

Patch Set 1 #

Patch Set 2 : Added feature_info unittest #

Total comments: 1

Patch Set 3 : Added suggested comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -2 lines) Patch
M gpu/command_buffer/common/gles2_cmd_utils.cc View 4 chunks +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 2 3 chunks +40 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 4 chunks +15 lines, -2 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
bajones
PTAL!
6 years, 2 months ago (2014-10-09 21:53:19 UTC) #2
Zhenyao Mo
The code looks good in general, but could you please add a test to feature_info_unittests.cc? ...
6 years, 2 months ago (2014-10-09 22:04:55 UTC) #3
bajones
On 2014/10/09 at 22:04:55, zmo wrote: > The code looks good in general, but could ...
6 years, 2 months ago (2014-10-10 23:19:53 UTC) #4
Zhenyao Mo
On 2014/10/10 23:19:53, bajones wrote: > On 2014/10/09 at 22:04:55, zmo wrote: > > The ...
6 years, 2 months ago (2014-10-10 23:45:36 UTC) #5
Ken Russell (switch to Gerrit)
LGTM too. https://codereview.chromium.org/638143003/diff/40001/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/638143003/diff/40001/gpu/command_buffer/service/texture_manager.cc#newcode1645 gpu/command_buffer/service/texture_manager.cc:1645: if (gfx::GetGLImplementation() == gfx::kGLImplementationDesktopGL) { Is this ...
6 years, 2 months ago (2014-10-11 03:20:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638143003/160001
6 years, 2 months ago (2014-10-13 20:10:30 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:160001)
6 years, 2 months ago (2014-10-13 21:39:07 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 21:39:53 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a2ea235a39a4b0bcad1f75934bdc09fb4d41733
Cr-Commit-Position: refs/heads/master@{#299371}

Powered by Google App Engine
This is Rietveld 408576698