Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Side by Side Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 638143003: Enabled EXT_sRGB WebGL extension support in the command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added suggested comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/feature_info.h" 5 #include "gpu/command_buffer/service/feature_info.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "gpu/command_buffer/service/gpu_service_test.h" 10 #include "gpu/command_buffer/service/gpu_service_test.h"
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 EXPECT_THAT(info_->extensions(), 246 EXPECT_THAT(info_->extensions(),
247 Not(HasSubstr("GL_ANGLE_texture_usage"))); 247 Not(HasSubstr("GL_ANGLE_texture_usage")));
248 EXPECT_THAT(info_->extensions(), 248 EXPECT_THAT(info_->extensions(),
249 Not(HasSubstr("GL_EXT_texture_storage"))); 249 Not(HasSubstr("GL_EXT_texture_storage")));
250 EXPECT_THAT(info_->extensions(), 250 EXPECT_THAT(info_->extensions(),
251 Not(HasSubstr("GL_OES_compressed_ETC1_RGB8_texture"))); 251 Not(HasSubstr("GL_OES_compressed_ETC1_RGB8_texture")));
252 EXPECT_THAT(info_->extensions(), 252 EXPECT_THAT(info_->extensions(),
253 Not(HasSubstr("GL_AMD_compressed_ATC_texture"))); 253 Not(HasSubstr("GL_AMD_compressed_ATC_texture")));
254 EXPECT_THAT(info_->extensions(), 254 EXPECT_THAT(info_->extensions(),
255 Not(HasSubstr("GL_IMG_texture_compression_pvrtc"))); 255 Not(HasSubstr("GL_IMG_texture_compression_pvrtc")));
256 EXPECT_THAT(info_->extensions(),
257 Not(HasSubstr("GL_EXT_sRGB")));
256 EXPECT_FALSE(info_->feature_flags().npot_ok); 258 EXPECT_FALSE(info_->feature_flags().npot_ok);
257 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 259 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
258 GL_COMPRESSED_RGB_S3TC_DXT1_EXT)); 260 GL_COMPRESSED_RGB_S3TC_DXT1_EXT));
259 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 261 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
260 GL_COMPRESSED_RGBA_S3TC_DXT1_EXT)); 262 GL_COMPRESSED_RGBA_S3TC_DXT1_EXT));
261 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 263 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
262 GL_COMPRESSED_RGBA_S3TC_DXT3_EXT)); 264 GL_COMPRESSED_RGBA_S3TC_DXT3_EXT));
263 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 265 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
264 GL_COMPRESSED_RGBA_S3TC_DXT5_EXT)); 266 GL_COMPRESSED_RGBA_S3TC_DXT5_EXT));
265 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 267 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 GL_TEXTURE_USAGE_ANGLE)); 317 GL_TEXTURE_USAGE_ANGLE));
316 EXPECT_FALSE(info_->validators()->texture_internal_format_storage.IsValid( 318 EXPECT_FALSE(info_->validators()->texture_internal_format_storage.IsValid(
317 GL_DEPTH_COMPONENT16)); 319 GL_DEPTH_COMPONENT16));
318 EXPECT_FALSE(info_->validators()->texture_internal_format_storage.IsValid( 320 EXPECT_FALSE(info_->validators()->texture_internal_format_storage.IsValid(
319 GL_DEPTH_COMPONENT32_OES)); 321 GL_DEPTH_COMPONENT32_OES));
320 EXPECT_FALSE(info_->validators()->texture_internal_format_storage.IsValid( 322 EXPECT_FALSE(info_->validators()->texture_internal_format_storage.IsValid(
321 GL_DEPTH24_STENCIL8_OES)); 323 GL_DEPTH24_STENCIL8_OES));
322 EXPECT_FALSE(info_->validators()->equation.IsValid(GL_MIN_EXT)); 324 EXPECT_FALSE(info_->validators()->equation.IsValid(GL_MIN_EXT));
323 EXPECT_FALSE(info_->validators()->equation.IsValid(GL_MAX_EXT)); 325 EXPECT_FALSE(info_->validators()->equation.IsValid(GL_MAX_EXT));
324 EXPECT_FALSE(info_->feature_flags().chromium_sync_query); 326 EXPECT_FALSE(info_->feature_flags().chromium_sync_query);
327 EXPECT_FALSE(info_->GetTextureFormatValidator(GL_SRGB_EXT).IsValid(
328 GL_UNSIGNED_BYTE));
329 EXPECT_FALSE(info_->GetTextureFormatValidator(GL_SRGB_ALPHA_EXT).IsValid(
330 GL_UNSIGNED_BYTE));
331 EXPECT_FALSE(info_->validators()->texture_format.IsValid(
332 GL_SRGB_EXT));
333 EXPECT_FALSE(info_->validators()->texture_format.IsValid(
334 GL_SRGB_ALPHA_EXT));
335 EXPECT_FALSE(info_->validators()->texture_internal_format.IsValid(
336 GL_SRGB_EXT));
337 EXPECT_FALSE(info_->validators()->texture_internal_format.IsValid(
338 GL_SRGB_ALPHA_EXT));
339 EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid(
340 GL_SRGB8_ALPHA8_EXT));
341 EXPECT_FALSE(info_->validators()->frame_buffer_parameter.IsValid(
342 GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING_EXT));
325 } 343 }
326 344
327 TEST_F(FeatureInfoTest, InitializeWithANGLE) { 345 TEST_F(FeatureInfoTest, InitializeWithANGLE) {
328 SetupInitExpectationsWithGLVersion("", kGLRendererStringANGLE, ""); 346 SetupInitExpectationsWithGLVersion("", kGLRendererStringANGLE, "");
329 EXPECT_TRUE(info_->feature_flags().is_angle); 347 EXPECT_TRUE(info_->feature_flags().is_angle);
330 } 348 }
331 349
332 TEST_F(FeatureInfoTest, InitializeNPOTExtensionGLES) { 350 TEST_F(FeatureInfoTest, InitializeNPOTExtensionGLES) {
333 SetupInitExpectations("GL_OES_texture_npot"); 351 SetupInitExpectations("GL_OES_texture_npot");
334 EXPECT_THAT(info_->extensions(), HasSubstr("GL_OES_texture_npot")); 352 EXPECT_THAT(info_->extensions(), HasSubstr("GL_OES_texture_npot"));
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 EXPECT_FALSE(info_->validators()->texture_format.IsValid( 446 EXPECT_FALSE(info_->validators()->texture_format.IsValid(
429 GL_BGRA_EXT)); 447 GL_BGRA_EXT));
430 EXPECT_FALSE(info_->validators()->texture_internal_format.IsValid( 448 EXPECT_FALSE(info_->validators()->texture_internal_format.IsValid(
431 GL_BGRA_EXT)); 449 GL_BGRA_EXT));
432 EXPECT_TRUE(info_->validators()->read_pixel_format.IsValid( 450 EXPECT_TRUE(info_->validators()->read_pixel_format.IsValid(
433 GL_BGRA_EXT)); 451 GL_BGRA_EXT));
434 EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid( 452 EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid(
435 GL_BGRA8_EXT)); 453 GL_BGRA8_EXT));
436 } 454 }
437 455
456 TEST_F(FeatureInfoTest, InitializeEXT_sRGB) {
457 SetupInitExpectations("GL_EXT_sRGB");
458 EXPECT_THAT(info_->extensions(),
459 HasSubstr("GL_EXT_sRGB"));
460 EXPECT_TRUE(info_->GetTextureFormatValidator(GL_SRGB_EXT).IsValid(
461 GL_UNSIGNED_BYTE));
462 EXPECT_TRUE(info_->GetTextureFormatValidator(GL_SRGB_ALPHA_EXT).IsValid(
463 GL_UNSIGNED_BYTE));
464 EXPECT_TRUE(info_->validators()->texture_format.IsValid(
465 GL_SRGB_EXT));
466 EXPECT_TRUE(info_->validators()->texture_format.IsValid(
467 GL_SRGB_ALPHA_EXT));
468 EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid(
469 GL_SRGB_EXT));
470 EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid(
471 GL_SRGB_ALPHA_EXT));
472 EXPECT_TRUE(info_->validators()->render_buffer_format.IsValid(
473 GL_SRGB8_ALPHA8_EXT));
474 EXPECT_TRUE(info_->validators()->frame_buffer_parameter.IsValid(
475 GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING_EXT));
476 }
477
438 TEST_F(FeatureInfoTest, InitializeEXT_texture_storage) { 478 TEST_F(FeatureInfoTest, InitializeEXT_texture_storage) {
439 SetupInitExpectations("GL_EXT_texture_storage"); 479 SetupInitExpectations("GL_EXT_texture_storage");
440 EXPECT_TRUE(info_->feature_flags().ext_texture_storage); 480 EXPECT_TRUE(info_->feature_flags().ext_texture_storage);
441 EXPECT_THAT(info_->extensions(), HasSubstr("GL_EXT_texture_storage")); 481 EXPECT_THAT(info_->extensions(), HasSubstr("GL_EXT_texture_storage"));
442 EXPECT_TRUE(info_->validators()->texture_parameter.IsValid( 482 EXPECT_TRUE(info_->validators()->texture_parameter.IsValid(
443 GL_TEXTURE_IMMUTABLE_FORMAT_EXT)); 483 GL_TEXTURE_IMMUTABLE_FORMAT_EXT));
444 EXPECT_FALSE(info_->validators()->texture_internal_format_storage.IsValid( 484 EXPECT_FALSE(info_->validators()->texture_internal_format_storage.IsValid(
445 GL_BGRA8_EXT)); 485 GL_BGRA8_EXT));
446 EXPECT_FALSE(info_->validators()->texture_internal_format_storage.IsValid( 486 EXPECT_FALSE(info_->validators()->texture_internal_format_storage.IsValid(
447 GL_RGBA32F_EXT)); 487 GL_RGBA32F_EXT));
(...skipping 854 matching lines...) Expand 10 before | Expand all | Expand 10 after
1302 1342
1303 TEST_F(FeatureInfoTest, InitializeNoCHROMIUM_path_rendering2) { 1343 TEST_F(FeatureInfoTest, InitializeNoCHROMIUM_path_rendering2) {
1304 SetupInitExpectationsWithGLVersion("GL_NV_path_rendering", "", "4.3"); 1344 SetupInitExpectationsWithGLVersion("GL_NV_path_rendering", "", "4.3");
1305 EXPECT_FALSE(info_->feature_flags().chromium_path_rendering); 1345 EXPECT_FALSE(info_->feature_flags().chromium_path_rendering);
1306 EXPECT_THAT(info_->extensions(), 1346 EXPECT_THAT(info_->extensions(),
1307 Not(HasSubstr("GL_CHROMIUM_path_rendering"))); 1347 Not(HasSubstr("GL_CHROMIUM_path_rendering")));
1308 } 1348 }
1309 1349
1310 } // namespace gles2 1350 } // namespace gles2
1311 } // namespace gpu 1351 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698