Issue 638063002: Cleanup: Add a NOTREACHED() when selecting a profile photo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 638063002: Cleanup: Add a NOTREACHED() when selecting a profile photo. (Closed)

Created:
6 years, 2 months ago by noms (inactive)

Modified:
6 years, 2 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, dbeam+watch-options_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Cleanup: Add a NOTREACHED() when selecting a profile photo. BUG=404241 Committed: https://crrev.com/914ea7553aa41bbadf927331a3f0d209551bc299 Cr-Commit-Position: refs/heads/master@{#299108}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/ui/webui/options/manage_profile_handler.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

Dan Beam

lgtm if you're trying to track this down for real users, this should probably be ...

6 years, 2 months ago (2014-10-09 18:04:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638063002/30001

6 years, 2 months ago (2014-10-10 13:39:52 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-10 14:03:48 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/914ea7553aa41bbadf927331a3f0d209551bc299
Cr-Commit-Position: refs/heads/master@{#299108}